Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes reassert and assert location #256

Merged
merged 5 commits into from
Feb 21, 2021
Merged

fixes reassert and assert location #256

merged 5 commits into from
Feb 21, 2021

Conversation

allenan
Copy link
Member

@allenan allenan commented Feb 20, 2021

This fixes a couple issues:

  • needed to increment nonce by 1
  • if past the "free" limit, skip the onboarding server part and let the wallet pay directly
  • make pending assert location txns show the mocked data and don't crash

matthewcarlreetz
matthewcarlreetz approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@matthewcarlreetz matthewcarlreetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. There's some TS stuff that could be cleaned up, but we can do that some other day.

tyler-whitman
tyler-whitman reviewed Feb 21, 2021
View reviewed changes
src/utils/walletClient.ts Outdated
@@ -7,6 +7,7 @@ const makeRequest = async (url: string, opts: RequestInit) => {
Logger.breadcrumb(`request: ${opts.method} ${url}`)
try {
const token = await getWalletApiToken()
// const token = undefined
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this

tyler-whitman
tyler-whitman approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@tyler-whitman tyler-whitman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, not sure if I can test it haha

@allenan allenan merged commit 7db9dec into main Feb 21, 2021
@allenan allenan deleted the fix/assert-location branch February 21, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewcarlreetz matthewcarlreetz matthewcarlreetz approved these changes

@tyler-whitman tyler-whitman tyler-whitman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allenan @matthewcarlreetz @tyler-whitman