This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Handle discovery mode packet forwarder tx timeout more gracefully. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayKickliter
suggested changes
Sep 14, 2021
|
Sure! I can try to statically analyze if that's possible. There are some other |
|
Ok. I trust your judgment. Add another comment when you decide one way or the other and I'll approve |
|
It's actually a good thing to visit. I get where you're coming from;
|
|
I can certainly imagine a |
There are several cases in which a packet transmission requested by Discovery Mode will succeed but not necessarily elicit an "`ok`" response. Handle those contingencies by plowing on, not crashing.
ke6jjj
force-pushed
the
jsc/disco-mode-graceful-timeout
branch
from
3d3c89c
to
2ae826a
Compare
|
Updated to handle |
JayKickliter
approved these changes
Sep 15, 2021
Vagabond
approved these changes
Sep 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible, though usually rare, that the request to transmit a discovery mode beacon packet might time out. When this happens, make sure not to crash the entire discovery mode session but simply move on to the next packet.
Should fix #1058, discovered by @maco2035