Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - Better Token Recognition #261

Closed
0xIchigo opened this issue Dec 19, 2023 · 10 comments
Closed

🐛 [BUG] - Better Token Recognition #261

0xIchigo opened this issue Dec 19, 2023 · 10 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@0xIchigo
Copy link
Contributor

0xIchigo commented Dec 19, 2023

Description

We do not properly display certain tokens under the Tokens page for an account. For example, in the screenshot provided, we do not display any token name or symbol for TheSolanDAO (7SZUnH7H9KptyJkUhJ5L4Kee5fFAbqVgCHvt7B6wg4Xc). This shouldn't be the case, as it is a recognized token on Jupiter and Solscan.

If a token does not have a picture, we should have a fallback picture. We do this when we can't fetch an asset's picture (see the second screenshot)

Reproduction URL

https://xray.helius.xyz/account/68VhXhZSQxBqC1fBLXnFb2tMiuh3tmiizpZKLTYTwgNG/tokens?network=mainnet

Reproduction steps

1. Go to https://xray.helius.xyz/account/68VhXhZSQxBqC1fBLXnFb2tMiuh3tmiizpZKLTYTwgNG/tokens?network=mainnet
2. See error

Screenshots

image
image

@0xIchigo 0xIchigo added bug Something isn't working good first issue Good for newcomers labels Dec 19, 2023
@kamalbuilds
Copy link

hey @0xIchigo , I would like to try my hands on this issue thanks

@0xIchigo
Copy link
Contributor Author

Hey @kamalbuilds, go for it! I just assigned the issue over to you

@0xIchigo
Copy link
Contributor Author

Hey @kamalbuilds, any update?

@ATREAY
Copy link

ATREAY commented Feb 4, 2024

gm @0xIchigo,

I attempted to replicate the issue by setting up the repository locally, but the tokens didn't show up. I believe API keys might be needed. Can we discuss this further on Twitter, Discord, or anywhere you prefer?

@0xIchigo
Copy link
Contributor Author

gm @ATREAY !

To build locally, fill in the following .env template with free Helius and Birdeye API keys. That should be everything you need to get started. If you need any additional help, I recommend opening up a support ticket in the Helius Discord

@shreyanshrathore
Copy link
Contributor

hey @0xIchigo, I would like to give it a try.

@shreyanshrathore
Copy link
Contributor

Hey @0xIchigo,
Regarding this issue, you've provided a fallback image to load instead of having no image. However, what should be the fallback for the name field? Since the token name isn't visible, should we include any alt text or not?

@0xIchigo
Copy link
Contributor Author

gm @shreyanshrathore, go for it! The fallback name should be something like "Unrecognized Token"

shreyanshrathore added a commit to shreyanshrathore/xray that referenced this issue Feb 26, 2024
@shreyanshrathore
Copy link
Contributor

Hey @0xIchigo, I have tried my best and fixed the issue. If you have any suggestions or anything that I can do to merge it into the code, please share it with me.

github-merge-queue bot pushed a commit that referenced this issue Feb 27, 2024
…Recognition

Fix #261 : Better Token Recognition
@0xIchigo
Copy link
Contributor Author

Fixed by #291 — thank you @shreyanshrathore for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants