Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-reload fails to change mouse configuration state #5648

Closed
dogunbound opened this issue Jan 23, 2023 · 1 comment · Fixed by #6675
Closed

config-reload fails to change mouse configuration state #5648

dogunbound opened this issue Jan 23, 2023 · 1 comment · Fixed by #6675
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR

Comments

@dogunbound
Copy link

Summary

config-reload does not change the mouse configuration state after modifying the config.toml

Reproduction Steps

Steps to reproduce:

  1. Run helix
  2. run :config-open
  3. modify the editor.mouse from true to false or false to true depending on your current configuration.
  4. run :config-reload

You will notice that the mouse state doesn't actually change.
You need to exit helix and open helix for the configuration to take place.

Helix log

helix.log

Platform

Linux

Terminal Emulator

konsole

Helix Version

22.12

@dogunbound dogunbound added the C-bug Category: This is a bug label Jan 23, 2023
@gabydd
Copy link
Member

gabydd commented Jan 23, 2023

thanks for opening up this issue:

this is where we disable mouse:

if self.config.load().editor.mouse {
execute!(stdout, EnableMouseCapture)?;
}

we need to either disable or enable mouse support the same way here:

fn refresh_config(&mut self) {

@kirawi kirawi added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors E-has-instructions Call for participation: Has instructions for fixing the issue and opening a PR
Projects
None yet
3 participants