Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouse configuration not getting updated after config-reload and set-option (#5648) #5931

Closed
wants to merge 1 commit into from
Closed

Conversation

johnfrankmorgan
Copy link

@johnfrankmorgan johnfrankmorgan commented Feb 11, 2023

Fixes #5648.

@pascalkuthe pascalkuthe added C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer. A-helix-term Area: Helix term improvements labels Feb 11, 2023
@gabydd
Copy link
Member

gabydd commented Feb 12, 2023

Works great! thanks for taking this on(I meant to get to it some point but I have been pretty busy with exams and university applications these past couple weeks)

gabydd
gabydd previously approved these changes Feb 12, 2023
@johnfrankmorgan
Copy link
Author

Works great! thanks for taking this on(I meant to get to it some point but I have been pretty busy with exams and university applications these past couple weeks)

No problem! Thanks for your detailed instructions in the issue, I wouldn't have know where to start without them!

Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the behavior for :config-reload but it would also be nice to fix :set-option as well. This block could be moved with some small modifications to handle_config_events after the self.editor.refresh_config() line

@johnfrankmorgan johnfrankmorgan changed the title Fix mouse configuration not getting updated after config-reload (#5648) Fix mouse configuration not getting updated after config-reload and set-option (#5648) Feb 12, 2023
@johnfrankmorgan
Copy link
Author

This fixes the behavior for :config-reload but it would also be nice to fix :set-option as well. This block could be moved with some small modifications to handle_config_events after the self.editor.refresh_config() line

Thanks for the suggestion! 😃 I wasn't entirely sure how best to handle the execute! result so I ended up adding a helper to refresh the mouse state. Let me know if you think the error handling should be moved out of handle_config_events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-bug Category: This is a bug E-easy Call for participation: Experience needed to fix: Easy / not much S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config-reload fails to change mouse configuration state
4 participants