Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a whichwrap option? #768

Open
irevoire opened this issue Sep 19, 2021 · 8 comments
Open

Is there a whichwrap option? #768

irevoire opened this issue Sep 19, 2021 · 8 comments
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements

Comments

@irevoire
Copy link
Contributor

Hello,

I would love to have a whichwrap option like in vim.
Basically, the idea would be that, when I'm at the end of a line and type right, I should just stay at the end of my line.
The same goes for the start of the line and left.

Is this something planned?

@irevoire irevoire added the C-enhancement Category: Improvements label Sep 19, 2021
@kirawi
Copy link
Member

kirawi commented Sep 20, 2021

From the documentation, it sounds like the Home (start line) and End (end line) keys. https://docs.helix-editor.com/keymap.html

@archseer
Copy link
Member

@kirawi you should read the linked documentation, it's about configuring this behavior, not about specific keys :P

@archseer
Copy link
Member

There's no configuration option and I'm not sure if we want this to be configurable.

Currently everything wraps: h/l used to stop at the end of line but after a discussion with @cessen we removed this limitation and had it match kakoune. I personally don't use this wrapping behavior, but what's the rationale for explicitly disabling it?

@irevoire
Copy link
Contributor Author

I would love to see this behaviour back, it was one of the reason why I went back to vim after using kakoune for ~6 months ☹️

(But overall I'm really in love with helix and don't plan to quit soon even if this behaviour is never implemented! Thanks for all the great works!)

@Omnikar
Copy link
Contributor

Omnikar commented Sep 20, 2021

I personally think this can be nice to have, if a bit niche, but I don't really think there's much of a reason not to make this configurable. Though it barely affects me, I think if it were configurable, I'd turn wrapping off.

@kirawi kirawi added the A-helix-term Area: Helix term improvements label Sep 21, 2021
@kirawi kirawi added the E-good-first-issue Call for participation: Issues suitable for new contributors label Nov 7, 2021
@the-mikedavis the-mikedavis linked a pull request Nov 28, 2022 that will close this issue
@yowayb
Copy link

yowayb commented Nov 19, 2023

@irevoire just curious what the benefit would be?

@ArijanJ
Copy link

ArijanJ commented Jan 6, 2024

curious what the benefit would be?

Just preventing complexity, IMO.

We've always had 4 directional keys, and making half of them go diagonally only at certain times is plain confusing.

@irevoire
Copy link
Contributor Author

irevoire commented Jan 9, 2024

Yeah, especially when you have multiple cursors and by hitting right one goes to the next line 😩
Even after two years of usage I still think about it at least once a day

@the-mikedavis the-mikedavis removed the E-good-first-issue Call for participation: Issues suitable for new contributors label Feb 15, 2024
pantos9000 added a commit to pantos9000/helix that referenced this issue Apr 23, 2024
Commands added:
* `move_same_line_char_left`
* `move_same_line_char_right`
* `extend_same_line_char_left`
* `extend_same_line_char_right`
* `append_mode_same_line`

These new commands move cursors, while making them stay in the same
line. So if a cursor would wrap around into another line, instead it
won't move and stay at its current position.
pantos9000 added a commit to pantos9000/helix that referenced this issue Apr 23, 2024
Commands added:
* `move_same_line_char_left`
* `move_same_line_char_right`
* `extend_same_line_char_left`
* `extend_same_line_char_right`
* `append_mode_same_line`

These new commands move cursors, while making them stay in the same
line. So if a cursor would wrap around into another line, instead it
won't move and stay at its current position.
pantos9000 added a commit to pantos9000/helix that referenced this issue Apr 25, 2024
* in case count > 1, move as far in the same line as possible without
  leaving it
* also adjust unit tests
pantos9000 added a commit to pantos9000/helix that referenced this issue May 1, 2024
pantos9000 added a commit to pantos9000/helix that referenced this issue May 2, 2024
Commands added:
* `move_same_line_char_left`
* `move_same_line_char_right`
* `extend_same_line_char_left`
* `extend_same_line_char_right`
* `append_mode_same_line`

These new commands move cursors, while making them stay in the same
line. So if a cursor would wrap around into another line, instead it
won't move and stay at its current position.
pantos9000 added a commit to pantos9000/helix that referenced this issue May 2, 2024
Commands added:
* `move_same_line_char_left`
* `move_same_line_char_right`
* `extend_same_line_char_left`
* `extend_same_line_char_right`
* `append_mode_same_line`

These new commands move cursors, while making them stay in the same
line. So if a cursor would wrap around into another line, instead it
won't move and stay at its current position.
pantos9000 added a commit to pantos9000/helix that referenced this issue Aug 26, 2024
Commands added:
* `move_same_line_char_left`
* `move_same_line_char_right`
* `extend_same_line_char_left`
* `extend_same_line_char_right`
* `append_mode_same_line`

These new commands move cursors, while making them stay in the same
line. So if a cursor would wrap around into another line, instead it
won't move and stay at its current position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants