Auto pairs selection #1254
Merged
Auto pairs selection #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
force-pushed
the
auto_pairs_selection
branch
2 times, most recently
from
f32c80f
to
78e4e83
Compare
dead10ck
force-pushed
the
auto_pairs_selection
branch
4 times, most recently
from
fd668ed
to
3f0f0e8
Compare
archseer
reviewed
Dec 15, 2021
dead10ck
force-pushed
the
auto_pairs_selection
branch
2 times, most recently
from
9857aca
to
3e471e4
Compare
|
@archseer is there anything else you'd like before this is merged? |
archseer
requested changes
Dec 20, 2021
archseer
requested changes
Dec 21, 2021
Previously, the auto pairs code was converting the user selection into its cursor form, and setting the transaction's selection to that cursor. This has the effect of destroying the user's selection if they type a pair character that gets auto completed. This fixes the code to work with the user's selection, inserting auto pairs where appropriate, but either keeping or extending the user's selection.
dead10ck
force-pushed
the
auto_pairs_selection
branch
from
d999060
to
9b056d9
Compare
archseer
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the auto pairs code was converting the user selection into its cursor form, and setting the transaction's selection to that cursor. This has the effect of destroying the user's selection if they type a pair character that gets auto completed.
This fixes the code to work with the user's selection, inserting auto pairs where appropriate, but either keeping or extending the user's selection.
This PR is built on top of #1219, so this PR includes commits from there as well until it is merged. I'll mark it as a draft until then.