-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade and reenable tree-sitter-haskell #1417
Upgrade and reenable tree-sitter-haskell #1417
Conversation
cb08936
to
c8a63a8
Compare
Looks like you'll have to enable C++11 in |
I see you also have a PR to drop the requirement to C++03: 414owen/tree-sitter-haskell#1 |
I'll see if I can get that touched up. |
c8a63a8
to
dc57ade
Compare
Okay I've changed |
This is great! You will probably also want to pull in the The current file predates the tree-sitter-haskell rewrite. |
dc57ade
to
d839931
Compare
@archseer Looks like those files were updated 19 days ago and 7 months ago, whereas the It certainly seems to be highlighting correctly when I test it. If not, what's the process here? Cross-reference helix's known token categories with what |
You should be able to copy the ones in the repo, and then what you'll have to do is change the captures (e.g. |
Okay everything in |
The worst mapping (preserved from before) is:
In haskell these are quantifiers, and have nothing to do with loops. I don't suppose |
Do you want to style these separately? If not, it's enough to use |
a1c52c1
to
54cb214
Compare
No that's okay. I've changed them to |
One last update to Think we're ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 🎉
After the changes to upgrade and reenable tree-sitter-haskell helix-editor#1417 for the purpose of enabling Haskell syntax highlighting helix-editor#1384, we might as well take the final step.
After the changes to upgrade and reenable tree-sitter-haskell helix-editor#1417 for the purpose of enabling Haskell syntax highlighting helix-editor#1384, we might as well take the final step.
I've made changes to
tree-sitter-haskell
that remove the need for c++14. It now happily compiles with c++11.I think this is ubiquitous enough to reenable it by default?