helix: reenable haskell syntax highlighting support #152279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haskell syntax highlighting is disabled in `helix-editor` by default. This is because of an issue compiling tree-sitter-haskell on M1 macs, as its default compiler doesn't support c++14. As we're using a nix-derived toolchain, we shouldn't be subject to this problem. See [this comment](helix-editor/helix#1384 (comment)) for more info.
|
Should the default I'd like at least a successful test report from aarch64-darwin. |
|
Closing in favour of reenabling Haskell support upstream: helix-editor/helix#1417 Unfortunately, the change didn't make it into 0.6.0, but maybe we'll get a minor release soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Haskell syntax highlighting is disabled in
helix-editorby default.This is because of an issue compiling tree-sitter-haskell on M1 macs,
as its default compilier doesn't support c++14.
As we're using a nix-derived toolchain, we shouldn't be subject to
this problem.
See this comment for more info.
Motivation for this change
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes