Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace shell_pipe_to with shell_pipe_popup #1988

Closed
wants to merge 2 commits into from

Conversation

gustafla
Copy link
Contributor

@gustafla gustafla commented Apr 6, 2022

The new shell_pipe_popup performs a similar function but also allows the user to see the output in an automatically closing popup.

I know this #1682 is similar, but I want selection piping and quick output feedback for running word counts.

@gustafla
Copy link
Contributor Author

gustafla commented Apr 6, 2022

I would otherwise maybe keep the output-ignoring variant of shell_pipe, but I couldn't find a reasonable working key mapping.

@the-mikedavis
Copy link
Member

I think it'd be good to keep shell_pipe_to around. It doesn't necessarily need a default keybinding, but having the command available lets people remap to it if they want, like

[keys.normal]
"|" = "shell_pipe_to"

@gustafla
Copy link
Contributor Author

gustafla commented Apr 6, 2022

I agree, my bad, didn't think about that I can just keep it there. Fixed.

The new shell_pipe_popup performs a similar function to shell_pipe_to but
also allows the user to see the output in an automatically closing popup.
@gustafla
Copy link
Contributor Author

gustafla commented Apr 6, 2022

Actually, I'd personally find this feature more useful if it joined all selections with spaces or newlines before piping to a single shell command. The current implementation runs n commands for n selections and shows n results in a popup.

@archseer
Copy link
Member

archseer commented May 2, 2022

I'd personally prefer the default keybinding and offer this as an alternative

@the-mikedavis the-mikedavis added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 18, 2022
@kirawi kirawi added A-helix-term Area: Helix term improvements S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2022
@pascalkuthe
Copy link
Member

closing this one out as stale. Thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants