Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple commands now shown in view #5203

Closed
wants to merge 1 commit into from
Closed

multiple commands now shown in view #5203

wants to merge 1 commit into from

Conversation

FrancescElies
Copy link
Contributor

Problem Once you start having multiple commands bind to a certain key int the config.toml they all appear get the Multiple commands description
imagen

# config.toml

[keys.normal.backspace]
b = ":sh cargo build"
c = [":config-open"]
s = [":w",":config-reload"]

That's ok but wouldn't it be better to see the real commands being executed?

This pr solves that.
imagen

@gibbz00
Copy link
Contributor

gibbz00 commented Dec 18, 2022

Aww man, I'm just about to send in a PR that will include the same fix, in addition to being able to give sequences their own name in the config :)

The PR is also a rework of a very messy keymap.rs, you can follow it at #5635

I will have to clean up the branch before sending it in, but the respective commit messages are quite descriptive for those interested in the thought process.

@the-mikedavis
Copy link
Member

Also see #3958

@pascalkuthe pascalkuthe added C-enhancement Category: Improvements A-helix-term Area: Helix term improvements S-waiting-on-review Status: Awaiting review from a maintainer. labels Dec 18, 2022
@FrancescElies
Copy link
Contributor Author

@gibbz00 @the-mikedavis @pascalkuthe if I understand correctly the sentiment here, this PR doesn't have good chances of getting merged, right?

If you prefer to wait for a more complete feature to be merged I am ok keeping this stuff in my fork until something better gets merged.

Shall I close this?

@the-mikedavis
Copy link
Member

I would prefer to wait for something customizable. The trouble with this representation is that it makes it look like you could execute multiple commands from command mode by separating them with ;. (I also have this nit for the current representation of typable commands though - :run-shell-command ["cargo", "build"] doesn't work for example.)

@FrancescElies
Copy link
Contributor Author

Alright, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants