Make mouse click extend selection in select mode #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
A-helix-term
kirawi
added
the
R-breaking-change
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
f18db9d
to
f6617c1
Compare
|
Conflicts with #5420. Rebased. |
|
Regarding the |
5 tasks
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
f6617c1
to
1c0a794
Compare
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
1c0a794
to
277de2b
Compare
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
277de2b
to
4c4a98f
Compare
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
4c4a98f
to
cfef31b
Compare
xJonathanLEI
force-pushed
the
dev/click_extend
branch
from
cfef31b
to
577cf91
Compare
archseer
removed
the
R-breaking-change
the-mikedavis
added
S-waiting-on-author
the-mikedavis
added
S-waiting-on-review
pascalkuthe
approved these changes
Feb 19, 2024
uek-1
pushed a commit
to uek-1/helix
that referenced
this pull request
Feb 24, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
shortc
pushed a commit
to shortc/helix
that referenced
this pull request
Mar 31, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
postsolar
pushed a commit
to postsolar/helix
that referenced
this pull request
Apr 4, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
mtoohey31
pushed a commit
to mtoohey31/helix
that referenced
this pull request
Jun 2, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
Vulpesx
pushed a commit
to Vulpesx/helix
that referenced
this pull request
Jun 7, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Make mouse click extend selection in select mode * chore: better readability with `Option::take()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5425. Design rationale detailed in #5425 comments.
I'm not entirely sure whether this change is desired, but am still submitting this optimistically as I think it makes a lot of sense. I use Helix on a touch screen device (phone) sometimes and find this extremely useful for selecting code blocks as touches are easier to do than key strokes on such devices. It annoys me that currently the only way to extend a selection would be to use a keyboard.
This PR should improve the mouse UX. It's now possible to extend the primary selection with mouse clicks. The original drag-to-yank behavior is also retained.
With this PR, the editor no longer collapses all selections into a single point on mouse clicks unconditionally. Instead, it extends the primary selection to the point click when it's in select mode (secondary selections are still discarded for consistency). Normal mode behavior is left untouched.