feat(dap): send Disconnect if Terminated event received #5532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipdutescu
commented
Jan 15, 2023
pascalkuthe
added
S-waiting-on-author
|
I have re-read the spec and I believe this part of the restart sequence to be correct. What needs to be done in addition is to expose a restart request, if supported, to the user, same as with launch, terminate etc. Cc: @pascalkuthe could we move it to waiting on review? Many thanks! |
pascalkuthe
added
S-waiting-on-review
filipdutescu
force-pushed
the
feat/dap_terminate_disconnect
branch
from
cce45ed
to
d8180a5
Compare
filipdutescu
force-pushed
the
feat/dap_terminate_disconnect
branch
from
d8180a5
to
90e1df2
Compare
filipdutescu
added a commit
to filipdutescu/helix
that referenced
this pull request
Jan 23, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
archseer
requested changes
Feb 1, 2023
pascalkuthe
added
S-waiting-on-author
filipdutescu
force-pushed
the
feat/dap_terminate_disconnect
branch
from
90e1df2
to
bde318b
Compare
the-mikedavis
added
S-waiting-on-review
archseer
requested changes
Feb 2, 2023
filipdutescu
force-pushed
the
feat/dap_terminate_disconnect
branch
from
bde318b
to
30462ff
Compare
Send a `Disconnect` DAP request if the `Terminated` event is received. According to the specification, if the debugging session was started by as `launch`, the debuggee should be terminated alongside the session. If instead the session was started as `attach`, it should not be disposed of. This default behaviour can be overriden if the `supportTerminateDebuggee` capability is supported by the adapter, through the `Disconnect` request `terminateDebuggee` argument, as described in [the specification][discon-spec]. This also implies saving the starting command for a debug sessions, in order to decide which behaviour should be used, as well as validating the capabilities of the adapter, in order to decide what the disconnect should do. An additional change made is handling of the `Exited` event, showing a message if the exit code is different than `0`, for the user to be aware off the termination failure. [discon-spec]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disconnect Closes: helix-editor#4674 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
|
@archseer implemented your comments, thanks very much for the patience and advice, I have learnt a lot and hopefully improved the way I write Rust. I also rebased the PR and squashed the commits, to make it a bit cleaner, since there are not that many modifications (hopefully) as to make it a chore to revisit the changes. |
archseer
approved these changes
Feb 20, 2023
|
No worries, thanks for reviewing and merging it! |
filipdutescu
added a commit
to filipdutescu/helix
that referenced
this pull request
Feb 20, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
archseer
pushed a commit
that referenced
this pull request
Mar 6, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon #5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: #5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
…#5532) Send a `Disconnect` DAP request if the `Terminated` event is received. According to the specification, if the debugging session was started by as `launch`, the debuggee should be terminated alongside the session. If instead the session was started as `attach`, it should not be disposed of. This default behaviour can be overriden if the `supportTerminateDebuggee` capability is supported by the adapter, through the `Disconnect` request `terminateDebuggee` argument, as described in [the specification][discon-spec]. This also implies saving the starting command for a debug sessions, in order to decide which behaviour should be used, as well as validating the capabilities of the adapter, in order to decide what the disconnect should do. An additional change made is handling of the `Exited` event, showing a message if the exit code is different than `0`, for the user to be aware off the termination failure. [discon-spec]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Disconnect Closes: helix-editor#4674 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send a
DisconnectDAP request if theTerminatedevent is received. According to the specification, if the debugging session was started by aslaunch, the debuggee should be terminated alongside the session. If instead the session was started asattach, it should not be disposed of.This default behaviour can be overriden if the
supportTerminateDebuggeecapability is supported by the adapter, through theDisconnectrequestterminateDebuggeeargument, as described inthe specification.
This also implies saving the starting command for a debug sessions, in order to decide which behaviour should be used, as well as validating the capabilities of the adapter, in order to decide what the disconnect should do.
An additional change made is handling of the
Exitedevent, showing a message if the exit code is different than0, for the user to be aware off the termination failure.Closes: #4674
Signed-off-by: Filip Dutescu filip.dutescu@gmail.com