feat(dap): implement Restart request #5651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-mikedavis
added
C-enhancement
|
This needs a rebase now |
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
filipdutescu
force-pushed
the
feat/dap_restart_request
branch
from
7e79268
to
896df50
Compare
|
Should all be good now |
archseer
approved these changes
Mar 6, 2023
sagnibak
pushed a commit
to sagnibak/helix
that referenced
this pull request
Mar 21, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
Add a restart debug session command, which would issue a [Restart Request][1], if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it. It builds upon helix-editor#5532, making use of the changes to the termination workflow of a session. [1]: https://microsoft.github.io/debug-adapter-protocol/specification#Requests_Restart Closes: helix-editor#5594 Signed-off-by: Filip Dutescu <filip.dutescu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a restart debug session command, which would issue a Restart Request, if the debugger supports it and a session is running. It uses the same arguments and requests used to start the initial session, when recreating it.
It builds upon #5532, making use of the changes to the termination workflow of a session.
Closes: #5594
Signed-off-by: Filip Dutescu filip.dutescu@gmail.com