Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix-toolkit reunion path? #1598

Closed
GeorgeS2019 opened this issue Jun 7, 2021 · 10 comments
Closed

Helix-toolkit reunion path? #1598

GeorgeS2019 opened this issue Jun 7, 2021 · 10 comments
Labels
Feature Request Request New Feature SharpDX

Comments

@GeorgeS2019
Copy link

GeorgeS2019 commented Jun 7, 2021

Currently Reunion 0.8 is now available with SwapChainPanel included for WinForm/WPF and UWP.

Project Reunion

Since Helix toolkit UWP Viewport is based on the UWP SwapChainPanel. I just curious is there interest to feature one or a few Helix-toolkit examples making use of the Project Reunion 0.8 SwapChainPanel.

@holance
Copy link
Member

holance commented Jun 8, 2021

I could not find the SwapChainPanel in Reunion project.

@SnowyWreath
Copy link
Contributor

Seems like it should be there; they're calling it the "Windows App SDK" now...

https://docs.microsoft.com/en-us/windows/winui/api/microsoft.ui.xaml.controls.swapchainpanel?view=winui-3.0

@miquik
Copy link
Contributor

miquik commented Jul 6, 2021

I just finish to convert UWP version to Project Reunion. It barely works, but there is much more work to do expecially in event handling

@holance holance added Feature Request Request New Feature SharpDX labels Jul 10, 2021
@miquik
Copy link
Contributor

miquik commented Jul 14, 2021

Here's my fork with a working example: Helix Toolkit - WinUI; it seems to works well

@holance
Copy link
Member

holance commented Jul 14, 2021

Is WinUI compatible with UWP? Or their namespaces are the same?

@miquik
Copy link
Contributor

miquik commented Jul 15, 2021

Is WinUI compatible with UWP? Or their namespaces are the same?

I modified UWP project to use with WinUI (I replace UWP namespace with WinUI - NET 5) for simplicity, so currently I can't merge it with main helix toolkit project. Anyway, with a little work, both versions (UWP and WinUI) can coexist.
WinUI version currently only works in Windows - Desktop (x86 and x64); I think this is a limitation of Project Reunion so far

@holance
Copy link
Member

holance commented Jul 15, 2021

Helix toolkit can only work on windows anyway, since directx only exists on windows.

@miquik
Copy link
Contributor

miquik commented Jul 15, 2021

Yes, you are right. Only Desktop

@miquik
Copy link
Contributor

miquik commented Aug 30, 2021

I would like to open a pull request for my contribution to WinUI version; I refactor my code now you can compile Wpf, UWP or WinUI version. Before opening the request (this is my first pull request ever) I have a consideration: to create this package I had to modify most of the files, so I don't know if it's the case to request to merge to the develop branch.

@holance
Copy link
Member

holance commented Aug 30, 2021

Go ahead to create a pull request. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request New Feature SharpDX
Projects
None yet
Development

No branches or pull requests

4 participants