Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Sleep UI #3

Merged
merged 10 commits into from
Sep 1, 2020
Merged

feat: New Sleep UI #3

merged 10 commits into from
Sep 1, 2020

Conversation

plahteenlahti
Copy link
Member

@plahteenlahti plahteenlahti commented Aug 23, 2020

Artboard 9

Description

Adds a completely new UI for both Sleep and Habits. This is a massive change, and the work will continue even after this. List of all the changes:

  • Fix a lot of linting errors
  • Adds new bed icon
  • Adds new Sleep UI
  • Adds new Habit UI
  • Update Intercom pod
  • Make use of import aliases in many places
  • Refactor SleepChart and add 8-hour target bars
  • Refactor and add types for animations
  • Fix translations
  • Fix selector problems

Still work left to be done. One major is getting rid of the day functionality and separating ratings and nights into their own states. The plan is to get rid of the sleepclock reducer and state completely and make it so that you can scroll years back, not just the amount of days in the store.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Locally
  • On device
  • Fresh install
  • Existing install

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@plahteenlahti plahteenlahti added the enhancement New feature or request label Aug 23, 2020
@plahteenlahti plahteenlahti merged commit fc53547 into master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant