Improve build #13
Merged
Improve build #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done by: - Switching to yarn to use package resolutions - Bump to latest version of TS (this allows us to use new TS features) - Bump to Jest v26 (v27 is out but ts-jest v27 changed it's api so that breaks tsdx)
edhedges
previously approved these changes
May 27, 2021
| "author": "Bloom Protocol LLC <team@bloom.co>", | ||
| "license": "Apache-2.0", | ||
| "respository": "https://github.com/hellobloom/ssi-sdk/tree/main/packages/credential-manifest", |
edhedges
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate Problem
There were some issues with the TS types so we needed to upgrade to the latest TS version. But because of how tsdx works it wasn't using the correct version of TS, the workaround is to use resolutions (but that only works with yarn)
Solution