Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a render_flashed_messages macro #5

Closed
wants to merge 1 commit into from

Conversation

neil-s
Copy link
Contributor

@neil-s neil-s commented Aug 1, 2018

Following up on #4 , and based on bootstrap-flask's implementation, with a name updated to match this project's naming style.

If you are open to this, I'll submit another commit to update the documentation and mention this macro.

I haven't fully tested this with Bootstrap 4.

Based on bootstrap-flask's implementation, with a name updated to match this project's naming style.
@coveralls
Copy link

coveralls commented Aug 1, 2018

Pull Request Test Coverage Report for Build 15

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.679%

Totals Coverage Status
Change from base Build 14: 0.0%
Covered Lines: 47
Relevant Lines: 53

💛 - Coveralls

@neil-s
Copy link
Contributor Author

neil-s commented Aug 1, 2018

OK this obviously doesn't work yet. Please ignore this PR, I'll update with commits that make it actually work.

@greyli
Copy link
Member

greyli commented Aug 2, 2018

Some advice:

  • Rewrite it to make it work with Bootstrap 4.
  • Let user to pass category name, note that there are 8 category types in Bootstrap 4.
  • Match default category (message) to primary alert (class="alert alert-primary").
  • Use standard Jinja syntax:
    • Yes: {{ variable }}
    • No: {{variable}}

@greyli greyli added this to the 1.1 milestone Mar 13, 2019
@SobieskiCodes
Copy link

Take it this is no longer on the board? Really the only thing missing.

@greyli
Copy link
Member

greyli commented Nov 17, 2019

@SobieskiCodes I'll implement this based on this PR. Please vote for the macro name!

@greyli greyli mentioned this pull request Nov 17, 2019
@greyli
Copy link
Member

greyli commented Nov 17, 2019

Thanks for working on this! This pr was replaced with #39.

@greyli greyli closed this Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants