Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hot code reloading in development mode #55

Closed
mgomes opened this issue Apr 8, 2018 · 4 comments · Fixed by #216
Closed

Enable hot code reloading in development mode #55

mgomes opened this issue Apr 8, 2018 · 4 comments · Fixed by #216
Assignees

Comments

@mgomes
Copy link
Member

mgomes commented Apr 8, 2018

Since we already require ActiveSupport, the ideal implementation for this would mimic what is done by Rails via http://api.rubyonrails.org/classes/ActiveSupport/Reloader.html. That has the advantage of working on Mac, Linux, and Windows as well as only reloading files that have changed. I've looked at gems like shotgun, but the Rails implementation of this seems to be the most robust.

@mgomes mgomes added this to the 1.0 milestone Apr 8, 2018
@mgomes mgomes self-assigned this Apr 8, 2018
@matthewblack matthewblack modified the milestones: 1.0, 1.1 May 22, 2018
@ghost
Copy link

ghost commented Jul 28, 2018

Is anyone working on this yet? I'd be interested in helping out a bit where possible.

@mgomes
Copy link
Member Author

mgomes commented Jul 28, 2018 via email

@ghost
Copy link

ghost commented Jul 28, 2018

Is it in a branch somewhere? I'm not sure where I'd start so I'd love to look at what there is. Happy to try and help along the way.

Just beginning my transition from just using Rails to actually learning Ruby ;) haha!

@mgomes
Copy link
Member Author

mgomes commented Jul 30, 2018

Here's where I ended up: https://github.com/hellostealth/stealth/tree/reloader

Not much luck though 😞

@mgomes mgomes modified the milestones: 1.1, 1.2 Oct 25, 2018
@mgomes mgomes modified the milestones: 1.2, 2.0 Feb 8, 2019
mgomes pushed a commit that referenced this issue Sep 17, 2019
Bumps [puma](https://github.com/puma/puma) from 4.0.1 to 4.1.0.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](puma/puma@v4.0.1...v4.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@mgomes mgomes removed this from the 2.0 milestone Sep 17, 2019
@mgomes mgomes mentioned this issue Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants