New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
glob not resolving dash-case-filenames #201
Labels
Comments
mbaldessari
pushed a commit
to mbaldessari/gitea-helm-chart
that referenced
this issue
Feb 10, 2024
…(#554) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [helm-unittest/helm-unittest](https://github.com/helm-unittest/helm-unittest) | patch | `0.3.4` -> `v0.3.6` | --- ### Release Notes <details> <summary>helm-unittest/helm-unittest (helm-unittest/helm-unittest)</summary> ### [`v0.3.6`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.6) [Compare Source](helm-unittest/helm-unittest@v0.3.5...v0.3.6) **Added Features** - Added templated Test Suites, to make re-usable tests possible (credits [@​hanseltime](https://github.com/hanseltime), resolves [#​57](helm-unittest/helm-unittest#57), resolves [#​186](helm-unittest/helm-unittest#186)) **Improvements** - Optimize installation (resolves [#​176](helm-unittest/helm-unittest#176), resolves [#​214](helm-unittest/helm-unittest#214), resolves [#​225](helm-unittest/helm-unittest#225)) **Fixes** - Fix incorrect filtering template files (resolves [#​219](helm-unittest/helm-unittest#219)) - Fix snapshot validator with Empty documents (credits [@​matthyx](https://github.com/matthyx)) - Fix inconsistent results lengthEqual validator (credits [@​hanseltime](https://github.com/hanseltime)) - Fix global values (credit [@​zidoshare](https://github.com/zidoshare), resolves [#​215](helm-unittest/helm-unittest#215)) **Updates** - Update packages to latest patch versions - Update documenation ### [`v0.3.5`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.5) [Compare Source](helm-unittest/helm-unittest@v0.3.4...v0.3.5) **Fixes** - Fix recursive subchart testing (credits [@​zidoshare](https://github.com/zidoshare), resolves [#​206](helm-unittest/helm-unittest#206)) - Fix old containsDocument behaviour to ignore other documents in multidocument validation (resolves [#​205](helm-unittest/helm-unittest#205)) - Fix failed_template to also work when empty documents are found (resolves [#​191](helm-unittest/helm-unittest#191)) - Fix failed_template multi colon handling (resolves [#​200](helm-unittest/helm-unittest#200)) - Fix glob all valid filenames (resolves [#​201](helm-unittest/helm-unittest#201)) **Updates** - Update packages to latest patch versions - Update documenation (thanks to [@​yariksheptykin](https://github.com/yariksheptykin)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NC4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/554 Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A snapshot spec defined like:
and a suite of files like:
the
dash-case-filename.yaml
file won't be picked up by the snapshot. Explicitly mentioning the file does seem to suffice as a work-around though. That is to say:suite: Full Snapshot templates: - '*.yaml' + - dash-case-filename.yaml tests: - it: matches the snapshot asserts: - matchSnapshot: {}
will include the
dash-case-filename.yaml
template in the snapshot.Is this expected behaviour? Helm docs seem to recommend using dashes in template filenames:
The text was updated successfully, but these errors were encountered: