Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glob not resolving dash-case-filenames #201

Closed
rperryng opened this issue Aug 29, 2023 · 0 comments · Fixed by #202
Closed

glob not resolving dash-case-filenames #201

rperryng opened this issue Aug 29, 2023 · 0 comments · Fixed by #202
Labels

Comments

@rperryng
Copy link

rperryng commented Aug 29, 2023

A snapshot spec defined like:

suite: Full Snapshot
templates:
  - '*.yaml'
tests:
  - it: matches the snapshot
    asserts:
      - matchSnapshot: {}

and a suite of files like:

❯ tree templates                       
templates
├── NOTES.txt
├── _helpers.tpl
├── dash-case-filename.yaml
├── deployment.yaml
├── hpa.yaml
├── ingress.yaml
├── service.yaml
└── serviceaccount.yaml

the dash-case-filename.yaml file won't be picked up by the snapshot. Explicitly mentioning the file does seem to suffice as a work-around though. That is to say:

suite: Full Snapshot
templates:
  - '*.yaml'
+ - dash-case-filename.yaml
tests:
  - it: matches the snapshot
    asserts:
      - matchSnapshot: {}

will include the dash-case-filename.yaml template in the snapshot.

Is this expected behaviour? Helm docs seem to recommend using dashes in template filenames:

Template file names should use dashed notation (my-example-configmap.yaml), not camelcase.

(source)

@quintush quintush added the bug label Aug 29, 2023
mbaldessari pushed a commit to mbaldessari/gitea-helm-chart that referenced this issue Feb 10, 2024
…(#554)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [helm-unittest/helm-unittest](https://github.com/helm-unittest/helm-unittest) | patch | `0.3.4` -> `v0.3.6` |

---

### Release Notes

<details>
<summary>helm-unittest/helm-unittest (helm-unittest/helm-unittest)</summary>

### [`v0.3.6`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.6)

[Compare Source](helm-unittest/helm-unittest@v0.3.5...v0.3.6)

**Added Features**

-   Added templated Test Suites, to make re-usable tests possible (credits [@&#8203;hanseltime](https://github.com/hanseltime), resolves [#&#8203;57](helm-unittest/helm-unittest#57), resolves [#&#8203;186](helm-unittest/helm-unittest#186))

**Improvements**

-   Optimize installation (resolves [#&#8203;176](helm-unittest/helm-unittest#176), resolves [#&#8203;214](helm-unittest/helm-unittest#214), resolves [#&#8203;225](helm-unittest/helm-unittest#225))

**Fixes**

-   Fix incorrect filtering template files (resolves [#&#8203;219](helm-unittest/helm-unittest#219))
-   Fix snapshot validator with Empty documents (credits [@&#8203;matthyx](https://github.com/matthyx))
-   Fix inconsistent results lengthEqual validator (credits [@&#8203;hanseltime](https://github.com/hanseltime))
-   Fix global values (credit [@&#8203;zidoshare](https://github.com/zidoshare), resolves [#&#8203;215](helm-unittest/helm-unittest#215))

**Updates**

-   Update packages to latest patch versions
-   Update documenation

### [`v0.3.5`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.5)

[Compare Source](helm-unittest/helm-unittest@v0.3.4...v0.3.5)

**Fixes**

-   Fix recursive subchart testing (credits [@&#8203;zidoshare](https://github.com/zidoshare), resolves [#&#8203;206](helm-unittest/helm-unittest#206))
-   Fix old containsDocument behaviour to ignore other documents in multidocument validation (resolves [#&#8203;205](helm-unittest/helm-unittest#205))
-   Fix failed_template to also work when empty documents are found (resolves [#&#8203;191](helm-unittest/helm-unittest#191))
-   Fix failed_template multi colon handling (resolves [#&#8203;200](helm-unittest/helm-unittest#200))
-   Fix glob all valid filenames (resolves [#&#8203;201](helm-unittest/helm-unittest#201))

**Updates**

-   Update packages to latest patch versions
-   Update documenation (thanks to [@&#8203;yariksheptykin](https://github.com/yariksheptykin))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NC4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/554
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants