Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure with v0.3.5 that it cannot find template file #219

Closed
camalot opened this issue Sep 18, 2023 · 7 comments · Fixed by #231
Closed

Failure with v0.3.5 that it cannot find template file #219

camalot opened this issue Sep 18, 2023 · 7 comments · Fixed by #231
Labels

Comments

@camalot
Copy link

camalot commented Sep 18, 2023

Getting error with version v0.3.5 that it is unable to locate the templates that are loaded by the test suite. this worked in v0.3.4

template "<chart-name>/templates/deployment-foo.yaml" not exists or not selected in test suite

---
suite: TEST SUITE
templates:
  - "deployment-foo.yaml"
values: []

tests:
  ...
@Lucavon
Copy link

Lucavon commented Sep 21, 2023

+1, can confirm this issue affects us too since 0.3.5.
We are currently forced to use 0.3.4.

@rhyswilliamsza
Copy link

@camalot - thanks for your action update - it helped us. Similar issue this side.

@quintush
Copy link
Contributor

Hello @camalot, @Lucavon, @rhyswilliamsza,

All Thanks for the update and confirfations.
Will check why this error occurred and will fix it.

Greetings,
@quintush

@quintush quintush added the bug label Sep 22, 2023
@Lucavon
Copy link

Lucavon commented Sep 22, 2023

Thanks! If you need @quintush I can try to provide an example where this issue occurs on monday or tuesday.

@knechtionscoding
Copy link

@quintush I will note this is only affecting some files for us.

about 40% aren't being found. The others are. Regardless of what they are called or what directory they are in.

gsautner added a commit to xwiki-contrib/xwiki-helm that referenced this issue Oct 10, 2023
- New unittest version indroduced new bug helm-unittest/helm-unittest#219
gsautner added a commit to xwiki-contrib/xwiki-helm that referenced this issue Oct 10, 2023
- New unittest version indroduced new bug helm-unittest/helm-unittest#219
@mgruener
Copy link

mgruener commented Oct 25, 2023

I am seeing the same problem and in my case the problem is triggered when the chart name is part of the template filename. I.e.
if "name" in "Chart.yaml" is "something" then all templates that have "something" in their name fail: "something-foo.yaml", "foo-something.yaml", "foosomethingbar.yaml"...

@vladimirblahoz
Copy link

I am seeing the same problem and in my case the problem is triggered when the chart name is part of the template filename. I.e. if "name" in "Chart.yaml" is "something" then all templates that have "something" in their name fail: "something-foo.yaml", "foo-something.yaml", "foosomethingbar.yaml"...

I just experienced the exact same thing with subchart containing the name of the parent child in its name

mbaldessari pushed a commit to mbaldessari/gitea-helm-chart that referenced this issue Feb 10, 2024
There is a regression that prevents us from going directly to 0.3.5.
To prevent the upcoming Renovate PR for 0.3.5 being stuck until 0.3.6,
we can use 0.3.4 until a working version is released.
The Renovate PR for 0.3.5 can then be closed directly so that Renovate
ignores that version.

helm-unittest/helm-unittest#219

Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/537
Co-authored-by: justusbunsi <sk.bunsenbrenner@gmail.com>
Co-committed-by: justusbunsi <sk.bunsenbrenner@gmail.com>
mbaldessari pushed a commit to mbaldessari/gitea-helm-chart that referenced this issue Feb 10, 2024
…(#554)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [helm-unittest/helm-unittest](https://github.com/helm-unittest/helm-unittest) | patch | `0.3.4` -> `v0.3.6` |

---

### Release Notes

<details>
<summary>helm-unittest/helm-unittest (helm-unittest/helm-unittest)</summary>

### [`v0.3.6`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.6)

[Compare Source](helm-unittest/helm-unittest@v0.3.5...v0.3.6)

**Added Features**

-   Added templated Test Suites, to make re-usable tests possible (credits [@&#8203;hanseltime](https://github.com/hanseltime), resolves [#&#8203;57](helm-unittest/helm-unittest#57), resolves [#&#8203;186](helm-unittest/helm-unittest#186))

**Improvements**

-   Optimize installation (resolves [#&#8203;176](helm-unittest/helm-unittest#176), resolves [#&#8203;214](helm-unittest/helm-unittest#214), resolves [#&#8203;225](helm-unittest/helm-unittest#225))

**Fixes**

-   Fix incorrect filtering template files (resolves [#&#8203;219](helm-unittest/helm-unittest#219))
-   Fix snapshot validator with Empty documents (credits [@&#8203;matthyx](https://github.com/matthyx))
-   Fix inconsistent results lengthEqual validator (credits [@&#8203;hanseltime](https://github.com/hanseltime))
-   Fix global values (credit [@&#8203;zidoshare](https://github.com/zidoshare), resolves [#&#8203;215](helm-unittest/helm-unittest#215))

**Updates**

-   Update packages to latest patch versions
-   Update documenation

### [`v0.3.5`](https://github.com/helm-unittest/helm-unittest/releases/tag/v0.3.5)

[Compare Source](helm-unittest/helm-unittest@v0.3.4...v0.3.5)

**Fixes**

-   Fix recursive subchart testing (credits [@&#8203;zidoshare](https://github.com/zidoshare), resolves [#&#8203;206](helm-unittest/helm-unittest#206))
-   Fix old containsDocument behaviour to ignore other documents in multidocument validation (resolves [#&#8203;205](helm-unittest/helm-unittest#205))
-   Fix failed_template to also work when empty documents are found (resolves [#&#8203;191](helm-unittest/helm-unittest#191))
-   Fix failed_template multi colon handling (resolves [#&#8203;200](helm-unittest/helm-unittest#200))
-   Fix glob all valid filenames (resolves [#&#8203;201](helm-unittest/helm-unittest#201))

**Updates**

-   Update packages to latest patch versions
-   Update documenation (thanks to [@&#8203;yariksheptykin](https://github.com/yariksheptykin))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NC4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Reviewed-on: https://gitea.com/gitea/helm-chart/pulls/554
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants