Allow completion tests to pass on github #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marckhouzam
force-pushed
the
test/ciFailures
branch
5 times, most recently
from
fe4c860
to
cc3b27e
Compare
marckhouzam
force-pushed
the
test/ciFailures
branch
2 times, most recently
from
bf5e1ad
to
8528bc8
Compare
|
Note sure what is happening but the docker image is not able to run helm. In the last build we can see: Note that everything works fine for completion outside of docker, but when we mount helm in docker, it give a No such file or directory error even though the file is there. |
marckhouzam
force-pushed
the
test/ciFailures
branch
2 times, most recently
from
f186cc2
to
5699554
Compare
marckhouzam
force-pushed
the
test/ciFailures
branch
5 times, most recently
from
09a7175
to
a02e37e
Compare
marckhouzam
force-pushed
the
test/ciFailures
branch
from
a02e37e
to
3bd284e
Compare
Signed-off-by: Marc Khouzam <marc.khouzam@montreal.ca>
marckhouzam
force-pushed
the
test/ciFailures
branch
from
3bd284e
to
61c95b1
Compare
|
The tests pass!!! |
akashshinde
added a commit
to akashshinde/acceptance-testing
that referenced
this pull request
Apr 8, 2020
* 'master' of github.com:helm/acceptance-testing: (41 commits) New helm global flags --kube-token and --kube-apiserver Add completion tests for release names Add completion tests for plugin completion Test kube-context completion without assuming kubectl Group related tests together Don't use a plugin named 'template' for completion Revert "Support if the help is either stdout or stderr (helm#64)" Update namespace flag tests for zsh Some fixes in preparation for plugin completion Make completion tests work with completion in Go Add completion test on centos Fix helm repo update not working Fix some of the KFAILs Fix the ZFAIL cases Support if the help is either stdout or stderr (helm#64) Print ERROR instead of FAIL Use linux image for docker (helm#60) fix: Helm 3 now supports the -c flag helm plugin 'remove' is now 'uninstall' maint: build helm 3 from master ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marc Khouzam marc.khouzam@montreal.ca