Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow completion tests to pass on github #60

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Allow completion tests to pass on github #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/completion-tests/test-completion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ if [[ "${GITHUB_SHA}" == "" ]]; then
cp ${CHECK_BINARY_PATH} ${COMP_DIR}/bin
else
echo "Running on GitHub Actions CI - using system-wide Helm 3 binary."
cp $(which helm) ${COMP_DIR}/bin
cp $(which helm-docker) ${COMP_DIR}/bin/helm
fi

# kubectl stub
Expand Down
5 changes: 3 additions & 2 deletions scripts/github-actions-ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ mkdir -p /tmp/gopath/src/helm.sh
pushd /tmp/gopath/src/helm.sh
git clone https://github.com/helm/helm.git -b master
pushd helm/
GOPATH=/tmp/gopath make build
GOPATH=/tmp/gopath make build build-cross
popd
popd
mv /tmp/gopath/src/helm.sh/helm/bin/helm bin/helm
mv /tmp/gopath/src/helm.sh/helm/_dist/linux-amd64/helm bin/helm-docker
helm version
which helm

Expand Down Expand Up @@ -60,7 +61,7 @@ kubectl version --client
which kubectl

# Install kind
which helm || true
which kind || true
curl -LO https://github.com/kubernetes-sigs/kind/releases/download/${KIND_VERSION}/kind-linux-amd64
chmod +x kind-linux-amd64
mv kind-linux-amd64 bin/kind
Expand Down