Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for --release-name-template flag #37

Closed
stevehipwell opened this issue Sep 1, 2020 · 7 comments
Closed

Add support for --release-name-template flag #37

stevehipwell opened this issue Sep 1, 2020 · 7 comments

Comments

@stevehipwell
Copy link

It would be really useful for the --release-name-template flag to be supported via the action. It might even be worth supporting flags in a generic way so new flags don't need changes to the action code.

helm/chart-releaser#74

@scottrigby
Copy link
Member

Hey 👋 yes! Once we cut a new release for helm/chart-released someone will add the new configs to this action... Stay tuned!

@isaaguilar
Copy link

When the new helm/chart-releaser get released, wouldn't env.CR_RELEASE_NAME_TEMPLATE be a way to use that flag in the cr upload command?

@stevehipwell
Copy link
Author

@scottrigby any news?

@cep21
Copy link

cep21 commented Sep 24, 2020

Hi,

My use case here is that I would like to put the chart in the same repository as the application itself. Using this action becomes confusing for consumers of my product since they see a new github release of the name "product-1.2" when I'm really just changing the chart. To resolve this, I would like to release the product itself as "product-1.2" and the chart for the product as "chart-product-x.y" so people are clear that the helm chart itself changed versions, but the product itself did not.

Thanks!

@llamahunter
Copy link

What's the status on this? I think many helm chart maintainers are going through pain right now because they are moving charts out of the helm stable/incubating repo and having trouble with chart naming in the process. Really need a way to control the release name to avoid collisions.

@stevehipwell
Copy link
Author

I think this can be closed now thanks to v1.1.0? It looks like setting the env variable CR_RELEASE_NAME_TEMPLATE should work.

@scottrigby
Copy link
Member

@stevehipwell You're correct! Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants