-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --skip-upload input with latest helm/chart-releaser-action #143
Conversation
Signed-off-by: acuD1 <arsciand@student.42.fr>
Signed-off-by: acuD1 <arsciand@student.42.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi, do you want me to rebase this branch to solve conflicts ? Greetings. |
@acuD1 able to fix the conflicts? I’ve been using your revision and it works well |
@jasonmoore2k rebased, instead of two Maybe there is a more elegant way to doing that, but it's less code added ;) |
lgtm |
can you please rebase? thanks |
@cpanato rebased. |
@davidkarlsen PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense - lgtm - thanks for the PR!
Could you create a release/tag with these changes? @cpanato |
Description
This PR introduces a new feature that allows skipping the
upload_index
parts in this action. The main motivation behind this change is to enable the use of OCI-based repositories for Helm with the Github Container Registry without managing the upload process of theindex.yaml
file.Changes Made:
Updated
README.md
: Added information about the new--skip-upload
option and its purpose.Updated
action.yaml
: Added the skip_upload input parameter to the action file.Updated
cr.sh
:--skip-upload
option to the script's usage information.main()
function to respect the skip_upload option.Ensured thatThis is handled directly in theupdate_index
is only called if theskip_upload
option is not set.update_index
function now.skip_upload
variable properly and passed it as an argument when callingupdate_index
.