Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index_md_path option to copy index.md path based on any file in the repository #31

Closed
wants to merge 1 commit into from

Conversation

vboulineau
Copy link

Add option to publish a file (typically README.md) to the GH Pages, allowing to easily display a homepage on Helm charts URL.

…he repository

Signed-off-by: Vincent Boulineau <vincent.boulineau@datadoghq.com>
@plumdog
Copy link

plumdog commented Dec 21, 2020

I have an interest in this feature, but it looks like it has stalled and now has conflicts.

If this were rebased (which I am willing to try to help with) might this feature get merged?

@vboulineau
Copy link
Author

Hey @plumdog,

I am also still interested to get this merge, and I can surely rebase it. However we'd some feedbacks from maintainers.

@cpanato
Copy link
Member

cpanato commented Feb 18, 2021

I'm ok with this change, need some rebase and also I would like to see comments from @scottrigby / @davidkarlsen / @unguiculus

@unguiculus
Copy link
Member

I'll have a look.

@unguiculus
Copy link
Member

What's the rationale behind this? Why don't you just add an index file once to the gh-pages branch? Why does that have to happen on every release?

@vboulineau
Copy link
Author

Because file content can change, the idea is to automate the publication. For instance if I want the README.md file to be index.md, I don't want the developer to have to think about copying the README.md to index.md in gh-pages whenever there is a change to it.

@davidkarlsen
Copy link
Member

I'm inclined to close this. I think it's an edge-case that's outside of scope for the action. This can be solved with vanilla github-actions configs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants