Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update releaser to regenerate generated field on index update #99

Merged
merged 1 commit into from
Feb 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file.
2 changes: 2 additions & 0 deletions pkg/releaser/releaser.go
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,8 @@ func (r *Releaser) UpdateIndexFile() (bool, error) {
fmt.Printf("Updating index %s\n", r.config.IndexPath)
indexFile.SortEntries()

indexFile.Generated = time.Now()

if err := indexFile.WriteFile(r.config.IndexPath, 0644); err != nil {
return false, err
}
Expand Down
43 changes: 40 additions & 3 deletions pkg/releaser/releaser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,12 @@ type FakeGitHub struct {

type MockClient struct {
statusCode int
file string
}

func (m *MockClient) Get(url string) (*http.Response, error) {
if m.statusCode == http.StatusOK {
file, _ := os.Open("testdata/repo/index.yaml")
file, _ := os.Open(m.file)
reader := bufio.NewReader(file)
return &http.Response{StatusCode: http.StatusOK, Body: ioutil.NopCloser(reader)}, nil
} else {
Expand Down Expand Up @@ -97,7 +98,7 @@ func TestReleaser_UpdateIndexFile(t *testing.T) {
PackagePath: "testdata/release-packages",
},
github: fakeGitHub,
httpClient: &MockClient{http.StatusOK},
httpClient: &MockClient{http.StatusOK, "testdata/repo/index.yaml"},
},
},
{
Expand All @@ -109,7 +110,7 @@ func TestReleaser_UpdateIndexFile(t *testing.T) {
PackagePath: "testdata/release-packages",
},
github: fakeGitHub,
httpClient: &MockClient{http.StatusNotFound},
httpClient: &MockClient{http.StatusNotFound, ""},
},
},
}
Expand All @@ -133,6 +134,42 @@ func TestReleaser_UpdateIndexFile(t *testing.T) {
}
}

func TestReleaser_UpdateIndexFileGenerated(t *testing.T) {
indexDir, _ := ioutil.TempDir(".", "index")
defer os.RemoveAll(indexDir)

fakeGitHub := new(FakeGitHub)

tests := []struct {
name string
releaser *Releaser
}{
{
"index-file-exists",
&Releaser{
config: &config.Options{
IndexPath: filepath.Join(indexDir, "index.yaml"),
PackagePath: "testdata/release-packages",
},
github: fakeGitHub,
httpClient: &MockClient{http.StatusOK, "testdata/empty-repo/index.yaml"},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
indexFile, _ := repo.LoadIndexFile("testdata/empty-repo/index.yaml")
generated := indexFile.Generated
update, err := tt.releaser.UpdateIndexFile()
assert.NoError(t, err)
assert.True(t, update)
newIndexFile, _ := repo.LoadIndexFile(tt.releaser.config.IndexPath)
newGenerated := newIndexFile.Generated
assert.True(t, newGenerated.After(generated))
})
}
}

func TestReleaser_splitPackageNameAndVersion(t *testing.T) {
tests := []struct {
name string
Expand Down
13 changes: 13 additions & 0 deletions pkg/releaser/testdata/empty-repo/index.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: v1
entries:
some-other-chart:
- apiVersion: v1
appVersion: "1.0"
created: "2019-03-29T22:50:44.754424+01:00"
description: A Helm chart for Kubernetes
digest: b61c67a17ac0215b45db5d4a60677d06993c772b1412c2dc32885ef7f49e4264
name: other-chart
urls:
- other-chart-0.0.1.tgz
version: 0.0.1
generated: "2019-03-29T22:50:44.751503+01:00"