helm upgrade uses reuse-values by default

[joejulian]

Is this a request for help?:

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

BUG REPORT

Version of Helm and Kubernetes:

version.BuildInfo{Version:"v3.11.0", GitCommit:"472c5736ab01133de504a826bd9ee12cbe4e7904", GitTreeState:"clean", GoVersion:"go1.19.5"}

ct version 2.7.1

What happened:
Upgrade failed when adding a new subchart in the new version because the new default chart values are ignored when reuse-values is specified. This caused the overrides in the new parent chart's values to be omitted and the subcharts defaults were used instead. As those overrides are required for the subchart to be a subchart, this caused the upgrade to fail.

When testing without reuse-values the upgrade is performed correctly.

Since using that flag is not a commonly documented way of upgrading charts, it should not be the default.

What you expected to happen:

I expected the common helm upgrade <release> <chart> --wait to be executed.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

[xDmitriev]

I faced the exactly same issue. When I added new items in values.yaml, ct install --upgrade is failed all the time since it does not respect new values

[xDmitriev]

Guys, what is the historical reason for having --reuse-values hardcoded here?

chart-testing/pkg/tool/helm.go

Line 74 in b8ad35c

"--reuse-values", "--wait", h.extraArgs, h.extraSetArgs); err != nil {

[xDmitriev]

@joejulian Does the upgrade mode work in your case, if you remove --reuse-values flag? Asking because it does not work in my case, I tried my own and your images, and there is a timed out waiting for the condition during the chart upgrade. But in fact, all pods getting ready after the upgrade, for some reason helm does not see that.

[joejulian]

@xDmitriev Yes, it works great.

[xDmitriev]

@xDmitriev Yes, it works great.

Could you please share your CLI arguments? Or is it just ct install --upgrade ?

[joejulian]

https://github.com/redpanda-data/helm-charts/blob/main/.github/workflows/pull_requests.yaml#L89

The config file is:
https://github.com/redpanda-data/helm-charts/blob/main/.github/ct.yaml

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This issue was closed because it has been stalled for 5 days with no activity.

[tthvo]

I think it is still useful to have and considering helm/helm#9653, we can also add support for --reset-then-reuse-values. Any on-going work to continue #531 @joejulian ?

I can try (relatively new here) and help take a look into it if needed :D