allow reuse-values on upgrade to be configurable #531
Conversation
many charts add new values between chart versions. When using the reuse-values flag, those charts fail because reuse-values ignores the default values file. By making this configurable, it allows the chart maintainer to determine whether it's appropriate for their chart to add new values when upgrading. Signed-off-by: Joe Julian <me@joejulian.name>
joejulian
force-pushed
the
configurable-reuse-values
branch
from
ecb72b3
to
aa94b9a
Compare
|
Yes, I've also noticed another inconsistency this can cause so I'll address that in this PR also |
|
Hey @joejulian, Have you gotten a chance to look at this yet? Would like for this PR to get merged, because any chart adding new values basically fails on testing because of this at the moment. Kind regards |
|
I'm going to close this for now. I'll re-do it when the --reset-and-reuse flag is added to helm. |
|
@joejulian now that feat(helm): Add --reset-then-reuse-values flag to 'helm upgrade' #9653 was merged, would you be able to re-open the PR? Or would you prefer me to help update docs + add test? Edit: I mistakenly thought new helm update has released 😅 apologies |
Yes, I'll work on that in the next week. |
|
Is there a plan to bring this up to the table again? |
What this PR does / why we need it:
many charts add new values between chart versions. When using the reuse-values flag, those charts fail because reuse-values ignores the default values file.
By making this configurable, it allows the chart maintainer to determine whether it's appropriate for their chart to add new values when upgrading.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #525Special notes for your reviewer: