Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-changed command #98

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Conversation

unguiculus
Copy link
Member

Allows to identify chart changes before actually running
lint or install commands. This can be useful in the following
cases:

  • In a CI setup where kind clusters are spun up on the fly,
    this makes it possible to decide whether a cluster is necessary
    at all. A PR may only contain changes that are not relevant
    to any charts.
  • By knowing upfront which charts have changed, it is
    possible to load a per-chart CI configuration which would
    allows us to determine the number of nodes needed in a kind
    cluster. For most charts, one node is enough, but in certain
    scenarios, especially for StatefulSets, we may want to test
    with pod anti-affinity where replicas have to be spread across
    multiple nodes.

Signed-off-by: Reinhard Nägele unguiculus@gmail.com

Allows to identify chart changes before actually running
lint or install commands. This can be useful in the following
cases:

* In a CI setup where kind clusters are spun up on the fly,
  this makes it possible to decide whether a cluster is necessary
  at all. A PR may only contain changes that are not relevant
  to any charts.
* By knowing upfront which charts have changed, it is
  possible to load a per-chart CI configuration which would
  allows us to determine the number of nodes needed in a kind
  cluster. For most charts, one node is enough, but in certain
  scenarios, especially for StatefulSets, we may want to test
  with pod anti-affinity where replicas have to be spread across
  multiple nodes.

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@unguiculus unguiculus merged commit d69c43e into helm:master Jan 31, 2019
@unguiculus unguiculus deleted the list-changed branch January 31, 2019 16:17
cpanato referenced this pull request in cpanato/chart-testing Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants