This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/spinnaker] fixes yaml code blocks formatting in README #10413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
size/M
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
fristonio
force-pushed
the
fix-stable-spinnaker-readme
branch
from
f3b1648
to
1ea9295
Compare
helm-bot
added
size/M
|
@viglesiasce Do I need to bump the version for this, since CircleCI shows this error in |
|
@fristonio I can confirm that you do indeed need to bump the chart version |
Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
helm-bot
added
size/M
dwardu89
approved these changes
Jan 8, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dwardu89, fristonio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…10413) * [stable/spinnaker] fixes yaml code blocks formatting in README Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com> * [stable/spinnaker] bump charts version Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
…10413) * [stable/spinnaker] fixes yaml code blocks formatting in README Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com> * [stable/spinnaker] bump charts version Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
hakamadare
pushed a commit
to hakamadare/charts
that referenced
this pull request
Jan 29, 2019
…10413) * [stable/spinnaker] fixes yaml code blocks formatting in README Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com> * [stable/spinnaker] bump charts version Signed-off-by: Deepesh Pathak <deepshpathak@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes YAML code blocks markdown rendering in
stable/spinnakerchart.What this PR does / why we need it:
This PR fixes yaml code blocks rendering in stable/spinnaker chart.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
@viglesiasce