-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/prometheus-operator] Updated to allow Ingress Capture Groups #12813
[stable/prometheus-operator] Updated to allow Ingress Capture Groups #12813
Conversation
Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
Hi @arthurvanduynhoven. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @gianrubio |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: arthurvanduynhoven, vsliouniaev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why was this released as a patch version bump and not a feature version bump for the chart version? |
…elm#12813) Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
…elm#12813) Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
…elm#12813) Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
…elm#12813) Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
What this PR does / why we need it:
With the latest nginx-ingress controller we now need to specify capture groups in our ingress rules. The Prometheus-Operator ingress rules do not allow this. This change allows the user to specify ingress rules separate from the routePrefix value.
Which issue this PR fixes
N/A
Special notes for your reviewer:
@gianrubio @vsliouniaev I also fixed some minor docs
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]