Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-operator] Updated to allow Ingress Capture Groups #12813

Conversation

arthurvanduynhoven
Copy link
Contributor

What this PR does / why we need it:

With the latest nginx-ingress controller we now need to specify capture groups in our ingress rules. The Prometheus-Operator ingress rules do not allow this. This change allows the user to specify ingress rules separate from the routePrefix value.

Which issue this PR fixes

N/A

Special notes for your reviewer:

@gianrubio @vsliouniaev I also fixed some minor docs

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @arthurvanduynhoven. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 4, 2019
@arthurvanduynhoven
Copy link
Contributor Author

/assign @gianrubio

@vsliouniaev
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arthurvanduynhoven, vsliouniaev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit eb4ba54 into helm:master Apr 4, 2019
@arthurvanduynhoven arthurvanduynhoven deleted the prometheus-operator/AllowCaptureGroupsForIngress branch April 4, 2019 13:28
@Starefossen
Copy link
Contributor

Starefossen commented Apr 5, 2019

Why was this released as a patch version bump and not a feature version bump for the chart version?

devnulled pushed a commit to devnulled/charts that referenced this pull request Apr 25, 2019
…elm#12813)

Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
dermorz pushed a commit to dermorz/charts that referenced this pull request Apr 26, 2019
…elm#12813)

Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
goshlanguage pushed a commit to goshlanguage/charts that referenced this pull request May 17, 2019
…elm#12813)

Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
eyenx pushed a commit to eyenx/charts that referenced this pull request May 28, 2019
…elm#12813)

Signed-off-by: Arthur Van Duynhoven <arthur.vanduynhoven@irdeto.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants