Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/metricbeat] Template dnsPolicy and hostNetwork #14675

Merged
merged 1 commit into from
Jun 11, 2019
Merged

[stable/metricbeat] Template dnsPolicy and hostNetwork #14675

merged 1 commit into from
Jun 11, 2019

Conversation

GreenKnight15
Copy link
Contributor

Template dnsPolicy and hostNetwork, add to README and default in values

Signed-off-by: James Ritter jamesritter15@gmail.com

What this PR does / why we need it:

Templates the hostNetwork and dnsPolicy values
The default values do not work in a cluster with Istio enabled

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@GreenKnight15
[stable/metricbeat] Template dnsPolicy and hostNetwork
023e891 
Template dnsPolicy and hostNetwork, add to README and default in values

Signed-off-by: James Ritter <jamesritter15@gmail.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 10, 2019
@helm-bot helm-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 10, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @GreenKnight15. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 10, 2019
@GreenKnight15
Copy link
Contributor Author

/assign @mumoshu

@mumoshu
Copy link
Collaborator

mumoshu commented Jun 11, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GreenKnight15, mumoshu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit d7e92de into helm:master Jun 11, 2019
@mumoshu
Copy link
Collaborator

mumoshu commented Jun 11, 2019

Thanks for your contribution @GreenKnight15 ☺️

anasinnyk pushed a commit to MacPaw/charts that referenced this pull request Jun 29, 2019
@GreenKnight15 @anasinnyk
[stable/metricbeat] Template dnsPolicy and hostNetwork (helm#14675)
c827013 
Template dnsPolicy and hostNetwork, add to README and default in values

Signed-off-by: James Ritter <jamesritter15@gmail.com>
Signed-off-by: Andrii Nasinnyk <anasinnyk@macpaw.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mumoshu mumoshu Awaiting requested review from mumoshu

Assignees

@mumoshu mumoshu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/metricbeat] Template daemonset dnsPolicy and hostNetwork
4 participants
@GreenKnight15 @k8s-ci-robot @mumoshu @helm-bot