Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/vault] Fix namespace #15461

Merged
merged 2 commits into from
Jul 11, 2019
Merged

[incubator/vault] Fix namespace #15461

merged 2 commits into from
Jul 11, 2019

Conversation

aravindvalkodaiqlik
Copy link
Contributor

@aravindvalkodaiqlik aravindvalkodaiqlik commented Jul 11, 2019 •
edited
Loading

Signed-off-by: Aravind Valkodai Aravind.Valkodai@qlik.com

What this PR does / why we need it:

Added the correct namespace based on the comments that was added here:
#14344 (comment)

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@aravindvalkodaiqlik
Add the correct namespace.
419a4c7 
Signed-off-by: Aravind Valkodai <Aravind.Valkodai@qlik.com>
@aravindvalkodaiqlik
Add the correct namespace.
8fbd3d7 
Signed-off-by: Aravind Valkodai <Aravind.Valkodai@qlik.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @aravindvalkodaiqlik. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 11, 2019
orirawlings
orirawlings approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@orirawlings orirawlings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jbialy
Copy link
Contributor

jbialy commented Jul 11, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 11, 2019
@jbialy
Copy link
Contributor

jbialy commented Jul 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindvalkodaiqlik, jbialy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
@k8s-ci-robot k8s-ci-robot merged commit e00bbe3 into helm:master Jul 11, 2019
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
@aravindvalkodaiqlik
[incubator/vault] Fix namespace (helm#15461)
eac6229 
* Add the correct namespace.

Signed-off-by: Aravind Valkodai <Aravind.Valkodai@qlik.com>

* Add the correct namespace.

Signed-off-by: Aravind Valkodai <Aravind.Valkodai@qlik.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orirawlings orirawlings orirawlings approved these changes

@jbialy jbialy jbialy approved these changes

@viglesiasce viglesiasce Awaiting requested review from viglesiasce

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aravindvalkodaiqlik @k8s-ci-robot @jbialy @orirawlings @helm-bot