This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/postgresql] Add dedicated tmpfs for /dev/shm. #19025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
the
Contribution Allowed
helm-bot
added
the
size/M
k8s-ci-robot
added
the
approved
desaintmartin
commented
Nov 20, 2019
desaintmartin
commented
Nov 20, 2019
stable/postgresql/README.md
Outdated
| @@ -116,6 +116,7 @@ The following tables lists the configurable parameters of the PostgreSQL chart a | |||
| | `service.loadBalancerIP` | loadBalancerIP if service type is `LoadBalancer` | `nil` | | |||
| | `service.loadBalancerSourceRanges` | Address that are allowed when svc is LoadBalancer | [] | | |||
| | `schedulerName` | Name of the k8s scheduler (other than default) | `nil` | | |||
| | `enableShmVolume` | Enable emptyDir volume for /dev/shm | `true` | | |||
There was a problem hiding this comment.
Is it okay for you to have, like persistence, one global value to enable for both master and slaves?
There was a problem hiding this comment.
Yes, but please add that information to the Description:
Enable emptyDir volume for /dev/shm both on master and slaves replicas
desaintmartin
changed the title
juan131
reviewed
Nov 21, 2019
There was a problem hiding this comment.
Thanks so much for this contribution! I quick question:
- Are containers affected by this limitation when using containerd as runtime too?
stable/postgresql/README.md
Outdated
| @@ -116,6 +116,7 @@ The following tables lists the configurable parameters of the PostgreSQL chart a | |||
| | `service.loadBalancerIP` | loadBalancerIP if service type is `LoadBalancer` | `nil` | | |||
| | `service.loadBalancerSourceRanges` | Address that are allowed when svc is LoadBalancer | [] | | |||
| | `schedulerName` | Name of the k8s scheduler (other than default) | `nil` | | |||
| | `enableShmVolume` | Enable emptyDir volume for /dev/shm | `true` | | |||
There was a problem hiding this comment.
Yes, but please add that information to the Description:
Enable emptyDir volume for /dev/shm both on master and slaves replicas
Hm, this is not clear: containerd/containerd#3654 states that the default is 64MB (with source as reference) and containerd/containerd@20d3fae solves it but I can't see this function called anywhere in containerd repo. |
|
Actually, I realized that if persistence is not enabled, chmod won't run. Fixing. |
Start a database pod without limitations on shm memory. By default docker limit to (see e.g. the [docker issue](docker-library/postgres#416), which could be not enough if PostgreSQL uses parallel workers heavily. If this option is present and value is , to the target database pod will be mounted a new tmpfs volume to remove this limitation. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
helm-bot
removed
the
Contribution Allowed
Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
helm-bot
added
the
Contribution Allowed
juan131
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
Thanks @desaintmartin !
Let's merge this and wait for docker/containerd to provide a better solution
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: desaintmartin, juan131 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JoseAlban
pushed a commit
to JoseAlban/charts
that referenced
this pull request
Nov 22, 2019
* [stable/postgresql] Add dedicated tmpsfs for /dev/shm. Start a database pod without limitations on shm memory. By default docker limit to (see e.g. the [docker issue](docker-library/postgres#416), which could be not enough if PostgreSQL uses parallel workers heavily. If this option is present and value is , to the target database pod will be mounted a new tmpfs volume to remove this limitation. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * [stable/postgresql] SHM: Second version after review + improvements. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
crmarques
pushed a commit
to crmarques/charts
that referenced
this pull request
Nov 29, 2019
* [stable/postgresql] Add dedicated tmpsfs for /dev/shm. Start a database pod without limitations on shm memory. By default docker limit to (see e.g. the [docker issue](docker-library/postgres#416), which could be not enough if PostgreSQL uses parallel workers heavily. If this option is present and value is , to the target database pod will be mounted a new tmpfs volume to remove this limitation. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * [stable/postgresql] SHM: Second version after review + improvements. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> Signed-off-by: Carlos Roberto Marques Junior <carlos.marques@bndes.gov.br>
hakman
pushed a commit
to hakman/charts
that referenced
this pull request
Dec 5, 2019
* [stable/postgresql] Add dedicated tmpsfs for /dev/shm. Start a database pod without limitations on shm memory. By default docker limit to (see e.g. the [docker issue](docker-library/postgres#416), which could be not enough if PostgreSQL uses parallel workers heavily. If this option is present and value is , to the target database pod will be mounted a new tmpfs volume to remove this limitation. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * [stable/postgresql] SHM: Second version after review + improvements. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
* [stable/postgresql] Add dedicated tmpsfs for /dev/shm. Start a database pod without limitations on shm memory. By default docker limit to (see e.g. the [docker issue](docker-library/postgres#416), which could be not enough if PostgreSQL uses parallel workers heavily. If this option is present and value is , to the target database pod will be mounted a new tmpfs volume to remove this limitation. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr> * [stable/postgresql] SHM: Second version after review + improvements. Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Start a database pod without limitations on shm memory. By default docker
limit to 64MB (see e.g. the docker
issue, which could be
not enough if PostgreSQL uses parallel workers heavily. If this option is
present and value is , to the target database pod will be mounted a new
tmpfs volume to remove this limitation.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])