Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/jaeger-operator] make compatible with helm3 #19212

Merged
merged 2 commits into from
Dec 5, 2019
Merged

[stable/jaeger-operator] make compatible with helm3 #19212

merged 2 commits into from
Dec 5, 2019

Conversation

kimxogus
Copy link
Contributor

@kimxogus kimxogus commented Nov 28, 2019 •
edited
Loading

Signed-off-by: Taehyun Kim kgyoo8232@gmail.com

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

No

What this PR does / why we need it:

  • This chart is incompatible with helm3 because of absence of .Capabilities.TillerVersion. This pr fixes it
  • Added crd.install
  • jaeger-operator version bump

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 28, 2019
@kimxogus
Copy link
Contributor Author

/assign @cpanato

@k8s-ci-robot
Copy link
Contributor

Hi @kimxogus. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 28, 2019
@scottrigby
Copy link
Member

In order for this to provide Helm 3 compatibility, the CRD will need to change. See my note in #19008. Specifically check out how it was done here:

Note #18721 uses a neat glob trick I'd like to see the other charts emulate 👍

@kimxogus kimxogus force-pushed the stable/jaeger-operator/helm3-compat branch from 3d1b701 to d1ee52c Compare December 2, 2019 01:23
@kimxogus
Copy link
Contributor Author

kimxogus commented Dec 2, 2019

@scottrigby Added crds.yaml as #18721 has done.

@kimxogus kimxogus force-pushed the stable/jaeger-operator/helm3-compat branch 2 times, most recently from 355d6c8 to 6221888 Compare December 3, 2019 01:49
@davidkarlsen
Copy link
Member

/ok-to-test
/assign
/lgtm

@kimxogus
Copy link
Contributor Author

kimxogus commented Dec 3, 2019

Is ci bot having issue?

@kimxogus kimxogus force-pushed the stable/jaeger-operator/helm3-compat branch from 6221888 to 8d9d457 Compare December 3, 2019 05:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2019
@kimxogus
make compatible with helm3
e386e01 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@kimxogus
add crds.yaml
98e5044 
Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@kimxogus kimxogus force-pushed the stable/jaeger-operator/helm3-compat branch from 8d9d457 to 98e5044 Compare December 3, 2019 16:49
@kimxogus
Copy link
Contributor Author

kimxogus commented Dec 5, 2019

@davidkarlsen CI seems to be broken in this pr. Can you re-label /ok-to-test?

@batazor
Copy link
Collaborator

batazor commented Dec 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: batazor, davidkarlsen, kimxogus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2eb6d2d into helm:master Dec 5, 2019
@kimxogus kimxogus deleted the stable/jaeger-operator/helm3-compat branch December 5, 2019 08:35
@kimxogus kimxogus mentioned this pull request Dec 5, 2019
Closed
18 tasks
@bala-striva
Copy link

I don't know if this is the right place to mention, but this is not working for us with helm v3.
The suggested reference (#18721) is different as it puts the crd files next to the templates folder and not in it.

charts/stable/jaeger-operator/templates/crds vs charts/stable/prometheus-operator/crds/

The helm reference (https://helm.sh/docs/topics/chart_best_practices/custom_resource_definitions/) also mentions the root level crds folder to be used to store the CRD manifest files.

hakman pushed a commit to hakman/charts that referenced this pull request Dec 5, 2019
@kimxogus
[stable/jaeger-operator] make compatible with helm3 (helm#19212)
2a4a8c3 
* make compatible with helm3

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>

* add crds.yaml

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
@scottrigby scottrigby mentioned this pull request Dec 13, 2019
Merged
4 tasks
WyriHaximus pushed a commit to WyriHaximus-labs/charts that referenced this pull request Dec 14, 2019
@kimxogus @WyriHaximus
[stable/jaeger-operator] make compatible with helm3 (helm#19212)
1dd6307 
* make compatible with helm3

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>

* add crds.yaml

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
dargolith pushed a commit to dargolith/charts that referenced this pull request Jan 10, 2020
@kimxogus @dargolith
[stable/jaeger-operator] make compatible with helm3 (helm#19212)
ca811d6 
* make compatible with helm3

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>

* add crds.yaml

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
arturrez pushed a commit to arturrez/stable-charts that referenced this pull request Jan 28, 2020
@kimxogus
[stable/jaeger-operator] make compatible with helm3 (helm#19212)
0fe6bb2 
* make compatible with helm3

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>

* add crds.yaml

Signed-off-by: Taehyun Kim <kgyoo8232@gmail.com>
Signed-off-by: Artur <artur@upbound.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@batazor batazor batazor approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[stable/jaeger-operator] No TillerVersion in minikube 1.4 and helm 3
8 participants
@kimxogus @k8s-ci-robot @scottrigby @davidkarlsen @batazor @bala-striva @cpanato @helm-bot