[stable/kong] Improve deployment label selector to not change on chart upgrades #19916
Conversation
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @rifelpet. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| app.kubernetes.io/component: app | ||
| app.kubernetes.io/instance: "{{ .Release.Name }}" |
There was a problem hiding this comment.
Should we change the selectors for the Service as well?
There was a problem hiding this comment.
ah, yea you're right. I just updated all the Services as well.
rifelpet
force-pushed
the
kong-label-selector
branch
from
dead03a
to
6dbfb37
Compare
helm-bot
added
size/M
…t upgrades Signed-off-by: Peter Rifel <pgrifel@gmail.com>
rifelpet
force-pushed
the
kong-label-selector
branch
from
6dbfb37
to
62010a1
Compare
|
/ok-tot-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbagdi, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…t upgrades (helm#19916) Signed-off-by: Peter Rifel <pgrifel@gmail.com>
…t upgrades (helm#19916) Signed-off-by: Peter Rifel <pgrifel@gmail.com> Signed-off-by: Artur <artur@upbound.io>
…t upgrades (helm#19916) Signed-off-by: Peter Rifel <pgrifel@gmail.com> Signed-off-by: Artur <artur@upbound.io>
Is this a new chart
No
What this PR does / why we need it:
In 0.35.0, the deployment's label selector changed. This adds a note with upgrade instructions because this field is immutable. It also removed the chart-version-specific labels from the label selector so that future upgrades can be performed in-place as well.
Which issue this PR fixes
Special notes for your reviewer:
Ideally we could offer an upgrade strategy that doesn't require downtime. I'm not sure how feasible that is though.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname])