Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-adapter] Defining a variable for listen port #21918

Merged
merged 2 commits into from
Apr 14, 2020
Merged

[stable/prometheus-adapter] Defining a variable for listen port #21918

merged 2 commits into from
Apr 14, 2020

Conversation

ali-sattari
Copy link
Contributor

What this PR does / why we need it:

Defines a variable for listen port of the application so it can be changed to the purpose.

Which issue this PR fixes

Special notes for your reviewer:

Changing the port for GKE deployment is the easiest approach since the firewall rules in GCP can't be easily updated through IaC and require extra software to be deployed.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@ali-sattari
Defining a variable for listen port
4aa2ba5 
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ali-sattari. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ali-sattari
Copy link
Contributor Author

/assign @MattiasGees

steven-sheehy
steven-sheehy suggested changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign
/ok-to-test

stable/prometheus-adapter/Chart.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2020
@ali-sattari
Bumping the version properly
477c14c 
Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
steven-sheehy
steven-sheehy approved these changes Apr 14, 2020
View reviewed changes
Copy link
Collaborator

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ali-sattari, steven-sheehy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit ca47667 into helm:master Apr 14, 2020
irlevesque pushed a commit to quantopian/charts that referenced this pull request Jul 13, 2020
@ali-sattari
[stable/prometheus-adapter] Defining a variable for listen port (helm…
8bf83de 
…#21918)

* Defining a variable for listen port

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>

* Bumping the version properly

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
includerandom pushed a commit to includerandom/helm_charts that referenced this pull request Jul 19, 2020
@ali-sattari @includerandom
[stable/prometheus-adapter] Defining a variable for listen port (helm…
6681fea 
…#21918)

* Defining a variable for listen port

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>

* Bumping the version properly

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
li-adrienloiseau pushed a commit to li-adrienloiseau/charts that referenced this pull request Jul 29, 2020
@ali-sattari @li-adrienloiseau
[stable/prometheus-adapter] Defining a variable for listen port (helm…
c664d54 
…#21918)

* Defining a variable for listen port

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>

* Bumping the version properly

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
Signed-off-by: Adrien Loiseau <adrien.loiseau@logic-immo.com>
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
@ali-sattari
[stable/prometheus-adapter] Defining a variable for listen port (helm…
d31eb94 
…#21918)

* Defining a variable for listen port

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>

* Bumping the version properly

Signed-off-by: Ali Sattari <ali.sattari@gmail.com>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@hectorj2f hectorj2f Awaiting requested review from hectorj2f

Assignees

@MattiasGees MattiasGees

@steven-sheehy steven-sheehy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ali-sattari @k8s-ci-robot @steven-sheehy @MattiasGees @helm-bot