-
Notifications
You must be signed in to change notification settings - Fork 16.8k
[stable/nfs-client-provisioner] Added ability to configure accessModes #22658
Conversation
Hi @samstride. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @verwilst |
/assign @davidkarlsen |
Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs. Signed-off-by: Vijay Madala. Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>
Bumped chart version. Signed-off-by: Vijay Madala Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
/ok-to-test |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
@davidkarlsen @verwilst , Hi, any chance this can be reviewed? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, samstride The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
helm#22658) * Enhancement Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs. Signed-off-by: Vijay Madala. Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local> * Update Chart.yaml Bumped chart version. Signed-off-by: Vijay Madala Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local> Co-authored-by: Vijay <darkknight@Darks-MacBook-Pro.local> Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs.
Signed-off-by: Vijay Madala.
Is this a new chart
What this PR does / why we need it:
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[stable/mychartname]
)