Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/nfs-client-provisioner] Added ability to configure accessModes #22658

Merged
merged 2 commits into from
Aug 13, 2020
Merged

[stable/nfs-client-provisioner] Added ability to configure accessModes #22658

merged 2 commits into from
Aug 13, 2020

Conversation

samstride
Copy link
Contributor

@samstride samstride commented Jun 3, 2020

Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs.

Signed-off-by: Vijay Madala.

Is this a new chart

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2020
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 3, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @samstride. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@samstride
Copy link
Contributor Author

/assign @verwilst

@samstride
Copy link
Contributor Author

/assign @davidkarlsen

Vijay added 2 commits June 4, 2020 10:53
Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs.

Signed-off-by: Vijay Madala.
Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>
Bumped chart version.

Signed-off-by: Vijay Madala
Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Jun 3, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2020
@davidkarlsen
Copy link
Member

/ok-to-test

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2020
@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 8, 2020
@samstride
Copy link
Contributor Author

@davidkarlsen @verwilst , Hi, any chance this can be reviewed?

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2020
@davidkarlsen
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, samstride

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 13, 2020
@k8s-ci-robot k8s-ci-robot merged commit a4a35c3 into helm:master Aug 13, 2020
mmingorance-dh pushed a commit to mmingorance-dh/charts that referenced this pull request Aug 28, 2020
helm#22658)

* Enhancement

Added ability to configure 'accessModes'. Default is 'ReadWriteOnce'. Also updated and aligned docs.

Signed-off-by: Vijay Madala.
Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>

* Update Chart.yaml

Bumped chart version.

Signed-off-by: Vijay Madala
Signed-off-by: Vijay <darkknight@Darks-MacBook-Pro.local>

Co-authored-by: Vijay <darkknight@Darks-MacBook-Pro.local>
Signed-off-by: Miguel Mingorance <miguel.mingorance@deliveryhero.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants