[incubator/solr]: add volumeClaimTemplates.enabled flag

[mcritchlow]

Is this a new chart

No.

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:

Similar to the Zookeeper chart it depends on, this enables a flag
allowing downstream users to decide whether they want PVCs created for
the StatefulSet.

This is particularly useful in review applications in a CI/CD
environment, which are inherently ephemeral, and PVCs cannot be
trivially removed via helm delete in a cleanup function.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• DCO signed
• Chart Version bumped
• Variables are documented in the README.md
• Title of the PR starts with chart name (e.g. [stable/mychartname])

[k8s-ci-robot]

Hi @mcritchlow. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mcritchlow
To complete the pull request process, please assign viglesiasce
You can assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[mcritchlow]

What is needed to get a review of this PR?

[mcritchlow]

/assign @viglesiasce

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[mcritchlow]

I'm very sorry to do this, but it's been well over 2 months and I noticed the last proposed Solr PR author had to do the same..

Could someone please take a look and let me know if this would be an acceptable change for this chart? Thank you.

@lachie83
@prydonius
@sameersbn
@viglesiasce
@unguiculus
@scottrigby
@mattfarina
@davidkarlsen
@paulczar
@cpanato
@jlegrone
@maorfr

[scottrigby]

Seems reasonable.

/ok-to-test

By the way, have you seen the stable and incubator repo deprecation timeline?

@ian-thebridge-lucidworks I wonder if you'd want to reclaim ownership of this chart?

For context see this issue https://github.com/helm/charts/issues/21103 though that's only tracking stable charts.

[mcritchlow]

@scottrigby - Thank you! I have seen the deprecation timeline, I'd be very interested to hear whether Lucidworks intends on resuming ownership of this chart as well. I work within a community that relies pretty heavily on Solr for various applications and, increasingly, this chart for Helm deployments. If Lucidworks doesn't intend on resuming ownership, I think we will probably consider it. Thanks again.

[scottrigby]

@mcritchlow nice 🙂 would you be willing to ask them and link to this issue?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[stale]

This issue is being automatically closed due to inactivity.