This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
new chart stable/mysqldump #4069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps the user backup mysql databases to a persistent volume
k8s-ci-robot
added
cncf-cla: yes
|
Please use the |
|
/assign |
|
thanks @unguiculus I actually skipped setting an app label as I wasn't sure if it was appropriate due to this being purely a job/cronjob. I'll go back and add it in. |
unguiculus
reviewed
Mar 9, 2018
| labels: | ||
| chart: "{{ .Chart.Name }}-{{ .Chart.Version }}" | ||
| release: "{{ .Release.Name }}" | ||
| heritage: "{{ .Release.Service }}" |
There was a problem hiding this comment.
You missed the app label here.
pierreozoux
reviewed
Mar 24, 2018
There was a problem hiding this comment.
Do you think a lot of people need this job? If we get rid of the job, we can simplify the chart.
What do you think of adding this cronjob to mysql chart instead? For me it would make sense.
For a future iteration, we could think of sending the backup to s3 too.
| @@ -0,0 +1,33 @@ | |||
| spec: | |||
| containers: | |||
| - name: xtrabackup | |||
There was a problem hiding this comment.
Why do you call it xtrabackup? It doesn't look like related to percona?
|
Any news on this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Activing will cause the issue to no longer be considered stale. Thank you for your contributions. |
mattfarina
added
the
lifecycle/stale
|
/retest |
stale
bot
removed
the
lifecycle/stale
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulczar, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
oliverisaac
added a commit
to oliverisaac/charts
that referenced
this pull request
Aug 15, 2018
new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable
k8s-ci-robot
pushed a commit
that referenced
this pull request
Aug 15, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump
marekaf
pushed a commit
to marekaf/charts
that referenced
this pull request
Sep 4, 2018
* new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
marekaf
pushed a commit
to marekaf/charts
that referenced
this pull request
Sep 4, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
marekaf
pushed a commit
to marekaf/charts
that referenced
this pull request
Sep 4, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump * Added external and internal GRPC port as options. Also added options to customize service annotations. Need these for istio config. * Updated README to include values I added. Reformatted the table so it reads pretty in plaintext * cockroach chart version bump for istio work Signed-off-by: Marek Bartik <mab@revolgy.com> Signed-off-by: Marek Bartik <bartimar6@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump * Added external and internal GRPC port as options. Also added options to customize service annotations. Need these for istio config. * Updated README to include values I added. Reformatted the table so it reads pretty in plaintext * cockroach chart version bump for istio work Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump Signed-off-by: aba182 <ajwilhel@gmail.com>
aba182
pushed a commit
to aba182/charts
that referenced
this pull request
Sep 7, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump * Added external and internal GRPC port as options. Also added options to customize service annotations. Need these for istio config. * Updated README to include values I added. Reformatted the table so it reads pretty in plaintext * cockroach chart version bump for istio work Signed-off-by: aba182 <ajwilhel@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
* [stable/cockroachdb] Added support for node selector * Merge with charts/stable * [stable/cockroachdb] Added support for node selector * [stable/cockroachdb] Added support for node selector new chart stable/mysqldump (helm#4069) * new chart stable/mysqldump Helps the user backup mysql databases to a persistent volume * use chart.name from tpl, add app label * add app/chart fixes to mysqldump-cron.yaml * fix backoffLimit in wrong place. * exit gracefully if db host not specified Merge with charts/stable * Chart version bump * Added external and internal GRPC port as options. Also added options to customize service annotations. Need these for istio config. * Updated README to include values I added. Reformatted the table so it reads pretty in plaintext * cockroach chart version bump for istio work Signed-off-by: Jakob Niggel <info@jakobniggel.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps the user backup mysql databases to a persistent volume