Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Use configuration options to bind to all interfaces #5261

Merged
merged 2 commits into from
May 9, 2018
Merged

Use configuration options to bind to all interfaces #5261

merged 2 commits into from
May 9, 2018

Conversation

pfisterer
Copy link
Contributor

What this PR does / why we need it:

It changes the configuration to use native Hadoop configuration options (cf. options for yarn and dfs) to bind to all interfaces instead of replacing the hostname with 0.0.0.0 using sed.

This avoids issues with webhdfs and URLs being generated that contain ...&namenoderpcaddress=0.0.0.0:9000&... instead of the hostname of the name node (e.g., ...&namenoderpcaddress=myrelease-hadoop-hdfs-nn:9000&...).

Special notes for your reviewer:

@danisla: I've tested this on a 4-node Kubernetes cluster without issues. I have deployed an instance of Apache Knox that exposes the webhdfs RESTful API for users outside of the cluster. After applying this fix, webhdfs access works.

…ing hostname with "0.0.0.0". This avoids issues with webhdfs.
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 26, 2018
@pfisterer
Copy link
Contributor Author

Increased the version number of the Chart.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 26, 2018
@k8s-ci-robot
Copy link
Contributor

@pfisterer: you can't request testing unless you are a kubernetes member.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pfisterer
Copy link
Contributor Author

/assign @viglesiasce

@danisla
Copy link
Contributor

danisla commented Apr 26, 2018

@pfisterer I just tried it with the mapreduce test and Zeppelin steps in the NOTES.txt and it looks good!

LGTM

@pfisterer
Copy link
Contributor Author

@danisla Tnx for looking into it

@timstoop
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2018
@timstoop
Copy link
Contributor

/assign

@pfisterer
Copy link
Contributor Author

@danisla Are you interested in a pull request that (optionally) adds Apache Knox (https://knox.apache.org/) to this chart? This allows, amongst other things, to access HDFS from outside the Kubernetes cluster.

@viglesiasce viglesiasce removed their assignment May 8, 2018
@unguiculus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pfisterer, unguiculus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2018
@k8s-ci-robot k8s-ci-robot merged commit f86d085 into helm:master May 9, 2018
ichtar pushed a commit to Bestmile/charts that referenced this pull request May 15, 2018
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs.

* Increase version number of the Chart
or1can pushed a commit to or1can/charts that referenced this pull request Jul 10, 2018
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs.

* Increase version number of the Chart
voron pushed a commit to dysnix/helm-charts that referenced this pull request Sep 5, 2018
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs.

* Increase version number of the Chart

Signed-off-by: voron <av@arilot.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants