-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Use configuration options to bind to all interfaces #5261
Conversation
…ing hostname with "0.0.0.0". This avoids issues with webhdfs.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Increased the version number of the Chart. |
@pfisterer: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @viglesiasce |
@pfisterer I just tried it with the mapreduce test and Zeppelin steps in the NOTES.txt and it looks good! LGTM |
@danisla Tnx for looking into it |
/ok-to-test |
/assign |
@danisla Are you interested in a pull request that (optionally) adds Apache Knox (https://knox.apache.org/) to this chart? This allows, amongst other things, to access HDFS from outside the Kubernetes cluster. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pfisterer, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs. * Increase version number of the Chart
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs. * Increase version number of the Chart
* Use configuration options to bind to all interfaces instead of replacing hostname with "0.0.0.0". This avoids issues with webhdfs. * Increase version number of the Chart Signed-off-by: voron <av@arilot.com>
What this PR does / why we need it:
It changes the configuration to use native Hadoop configuration options (cf. options for yarn and dfs) to bind to all interfaces instead of replacing the hostname with
0.0.0.0
usingsed
.This avoids issues with webhdfs and URLs being generated that contain
...&namenoderpcaddress=0.0.0.0:9000&...
instead of the hostname of the name node (e.g.,...&namenoderpcaddress=myrelease-hadoop-hdfs-nn:9000&...
).Special notes for your reviewer:
@danisla: I've tested this on a 4-node Kubernetes cluster without issues. I have deployed an instance of Apache Knox that exposes the webhdfs RESTful API for users outside of the cluster. After applying this fix, webhdfs access works.