-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Conversation
…rendertron images.
Hi @ravishivt. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the lint failures.
# Various IDEs | ||
.project | ||
.idea/ | ||
*.tmproj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cam you add the OWNERS file to this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
stable/rendertron/values.yaml
Outdated
replicaCount: 1 | ||
image: | ||
repository: ravishi/rendertron | ||
tag: a6b93ee7ca98687610542ac930597ce5064762d2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this to a tag rather than a hash? Possibly a version that correlates to the a software version?
# Declare variables to be passed into your templates. | ||
replicaCount: 1 | ||
image: | ||
repository: ravishi/rendertron |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image repo is manually built and only 4 pulls at the moment. Is there a better version of this image to use? Possibly one with automation or a pointer back to the config used to build it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, there is no better image/repo to use. I've requested the rendertron project to publish official docker images in GoogleChrome/rendertron#93. Until that happens, I am building a pushing images myself.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ravishivt If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… charts such as kibana
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
This issue is being automatically closed due to inactivity. |
What this PR does / why we need it:
Adds a new stable chart for rendertron. This is a useful utility to achieve SEO support for JS web apps (react, angular, vue).