Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/elasticsearch] Promote elasticsearch to stable #7180

Closed

Conversation

rendhalver
Copy link
Collaborator

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rendhalver
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lachie83

If they are not already assigned, you can assign the PR to them by writing /assign @lachie83 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2018
@timstoop
Copy link
Contributor

I'd say the documentation needs a bit of a rewrite (at the very least, mentions of "up to v5" should be changed to "up to v6"). Not sure if this should be done before the Chart is promoted? Also, there's been another merge on the incubator Chart.

@rendhalver
Copy link
Collaborator Author

Thanks @timstoop That's a good plan. I will redo this.

@mattfarina mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018
@monotek
Copy link
Collaborator

monotek commented Sep 3, 2018

Any update?
I also like to do a pr but like to wait until its promoted to stable...

@rendhalver
Copy link
Collaborator Author

I will get this fixed as soon as I can.

@stale
Copy link

stale bot commented Oct 4, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2018
@rendhalver rendhalver mentioned this pull request Oct 15, 2018
3 tasks
@rendhalver
Copy link
Collaborator Author

rendhalver commented Oct 15, 2018

I have closing this in favour of #8476

@rendhalver rendhalver closed this Oct 15, 2018
@rendhalver rendhalver deleted the promote-elasticsearch-to-stable branch October 15, 2018 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants