Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/sonarqube] added parameter for custom mysql parameters #7925

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

razaj92
Copy link
Contributor

@razaj92 razaj92 commented Sep 24, 2018

Signed-off-by: Raza Jhaveri razajhaveri@googlemail.com

What this PR does / why we need it:

Allows adding additional parameters to the JDBC connection string for SonarQube. This is useful to add options such as useSSL=true when connecting to a remote DB

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [ x ] DCO signed
  • [ x ] Chart Version bumped
  • [ x ] Variables are documented in the README.md

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 24, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 24, 2018
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 25, 2018
@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Sep 25, 2018
@@ -1,6 +1,6 @@
name: sonarqube
description: Sonarqube is an open sourced code quality scanning tool
version: 0.9.1
version: 0.9.2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the minor version as this adds a feature.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Thats done now.

Thanks

@rjkernick
Copy link
Collaborator

/assign
/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2018
Signed-off-by: Raza Jhaveri <razajhaveri@googlemail.com>
@rjkernick
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razaj92, rjkernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2018
@k8s-ci-robot k8s-ci-robot merged commit 85c0380 into helm:master Sep 28, 2018
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
…7925)

Signed-off-by: Raza Jhaveri <razajhaveri@googlemail.com>
Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
…7925)

Signed-off-by: Raza Jhaveri <razajhaveri@googlemail.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
…7925)

Signed-off-by: Raza Jhaveri <razajhaveri@googlemail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants