Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

concourse: consume local-users from k8s secret #8099

Merged
merged 1 commit into from
Nov 4, 2018
Merged

concourse: consume local-users from k8s secret #8099

merged 1 commit into from
Nov 4, 2018

Conversation

chrishiestand
Copy link
Contributor

instead of directly from helm chart. k8s secret will use the chart value
as a default, so functionality is not lost

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 2, 2018
@matthope
Copy link
Contributor

matthope commented Oct 3, 2018 •
edited
Loading

Wouldn't this also need to update templates/secrets.yaml ?

#8094 has an example of what I would have expected to see

@chrishiestand
Copy link
Contributor Author

@matthope I should have been more clear. local-users was already set in secrets.yaml which is why I didn't have to add it. It seems to have been intended to be used, but the secret is not consumed by the deployment. https://github.com/kistek/charts/blob/9fec4ff93895bf93ca1dd9893fc45ce6f443038e/stable/concourse/templates/secrets.yaml#L30

@matthope
Copy link
Contributor

matthope commented Oct 9, 2018

@chrishiestand Cheers- thats clearer :)
FYI, you may need to read https://www.helm.sh/blog/helm-dco/index.html to pass the DCO/dco-labler checks.

@ey-bot ey-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 9, 2018
@chrishiestand
Copy link
Contributor Author

Thanks @matthope, I didn't even know DCO was a standard thing. Fixed.

@william-tran
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 11, 2018
@william-tran
Copy link
Collaborator

@chrishiestand please resolve conflicts / chart version bump and you could be next!

@william-tran
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2018
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2018
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2018
@chrishiestand
Copy link
Contributor Author

@william-tran please review again after conflict resolution and bump

@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2018
@chrishiestand
concourse: consume local-users from k8s secret
8a3ebc2 
instead of directly from helm chart. k8s secret will use the chart value
 as a default, so functionality is not lost

Signed-off-by: Chris Hiestand <chrishiestand@gmail.com>
@helm-bot helm-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 3, 2018
@william-tran
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrishiestand, william-tran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit db4db2b into helm:master Nov 4, 2018
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@chrishiestand @wgiddens
concourse: consume local-users from k8s secret (helm#8099)
9c833df 
instead of directly from helm chart. k8s secret will use the chart value
 as a default, so functionality is not lost

Signed-off-by: Chris Hiestand <chrishiestand@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@william-tran william-tran william-tran approved these changes

@frodenas frodenas Awaiting requested review from frodenas

Assignees

@william-tran william-tran

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concourse] local users should be consumed from secret
6 participants
@chrishiestand @matthope @william-tran @k8s-ci-robot @ey-bot @helm-bot