This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[incubator/schema-registry] Kafkastore.replication.factor is unused #8398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Alvarez <dominalexican@gmail.com>
Signed-off-by: Alex Alvarez <dominalexican@gmail.com>
helm-bot
added
the
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
3 tasks
|
/ok-to-test |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexander-alvarez, benjigoldberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
darioblanco
pushed a commit
to minddocdev/charts
that referenced
this pull request
Oct 22, 2018
…elm#8398) * Replication factor does not make sense for consumer Signed-off-by: Alex Alvarez <dominalexican@gmail.com> * bumping version Signed-off-by: Alex Alvarez <dominalexican@gmail.com>
emas80
pushed a commit
to faceit/charts
that referenced
this pull request
Oct 24, 2018
…elm#8398) * Replication factor does not make sense for consumer Signed-off-by: Alex Alvarez <dominalexican@gmail.com> * bumping version Signed-off-by: Alex Alvarez <dominalexican@gmail.com>
Jnig
pushed a commit
to Jnig/charts
that referenced
this pull request
Nov 13, 2018
…elm#8398) * Replication factor does not make sense for consumer Signed-off-by: Alex Alvarez <dominalexican@gmail.com> * bumping version Signed-off-by: Alex Alvarez <dominalexican@gmail.com> Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
…elm#8398) * Replication factor does not make sense for consumer Signed-off-by: Alex Alvarez <dominalexican@gmail.com> * bumping version Signed-off-by: Alex Alvarez <dominalexican@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Since the schema registry is a consumer, the property doesn't make sense -- a warning shows up in the logs saying that the property is unused
kafkastore.topic.replication.factorWhich issue this PR fixes
N/A -- Misleading / unused property
Special notes for your reviewer:
N/A
Checklist