Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/owncloud] Add global registry option #8455

Merged
merged 2 commits into from
Oct 16, 2018
Merged

[stable/owncloud] Add global registry option #8455

merged 2 commits into from
Oct 16, 2018

Conversation

carrodher
Copy link
Collaborator

Signed-off-by: Carlos Rodriguez Hernandez crhernandez@bitnami.com

  • Add global.registry at the top of values.yaml (commented out at the beginning).
  • Add the required logic to use the global value if it is defined.
  • Add a link to the values.yaml of the dependency in the main values.yaml chart (in the section of the dependency options).

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Oct 15, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2018
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Copy link
Collaborator

@tompizmor tompizmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carrodher, tompizmor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3909fc6 into helm:master Oct 16, 2018
@carrodher carrodher deleted the owncloud branch October 16, 2018 08:47
darioblanco pushed a commit to minddocdev/charts that referenced this pull request Oct 22, 2018
* [stable/owncloud] Add global registry option

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>

* Update deps

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
emas80 pushed a commit to faceit/charts that referenced this pull request Oct 24, 2018
* [stable/owncloud] Add global registry option

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>

* Update deps

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
* [stable/owncloud] Add global registry option

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>

* Update deps

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
* [stable/owncloud] Add global registry option

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>

* Update deps

Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants