This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/keycloak] use tcp instead of udp for jgroups #9040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @dojadop. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dojadop
force-pushed
the
fixHaKeycloak
branch
from
36f8bc2
to
c3e5643
Compare
helm-bot
added
size/XS
unguiculus
suggested changes
Nov 9, 2018
helm-bot
added
size/XS
dojadop
force-pushed
the
fixHaKeycloak
branch
from
ff6fd5f
to
f617792
Compare
helm-bot
added
size/XS
dojadop
force-pushed
the
fixHaKeycloak
branch
from
f617792
to
8c45773
Compare
helm-bot
added
size/XS
unguiculus
approved these changes
Nov 9, 2018
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
and removed
needs-ok-to-test
* add note on PROXY_ADDRESS_FORWARDING when using ingress * fixes helm#8355 Signed-off-by: Michael Dop <michael.p.dop@gmail.com>
Signed-off-by: Michael Dop <michael.p.dop@gmail.com>
Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
unguiculus
force-pushed
the
fixHaKeycloak
branch
from
8c45773
to
a311f84
Compare
helm-bot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dojadop, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
* [stable/keycloak] use tcp instead of udp for jgroups * add note on PROXY_ADDRESS_FORWARDING when using ingress * fixes helm#8355 Signed-off-by: Michael Dop <michael.p.dop@gmail.com> * Remove PROXY_ADDRESS_FORWARDING comment Signed-off-by: Michael Dop <michael.p.dop@gmail.com> * Bump version Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Dop michael.p.dop@gmail.com
What this PR does / why we need it:
The default jgroups protocol is udp so need to change back to tcp. When using udp the the nodes cannot communicate to each other and start timing out causing ha keycloak to fail when using DNS_PING.
Which issue this PR fixes
Special notes for your reviewer: