[incubator/cassandra] change backup image, add parallel to values #9193
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maorfr If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @maorfr. Thanks for your PR. I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Maor <maor.friedman@nuvo-group.com>
Signed-off-by: Maor <maor.friedman@nuvo-group.com>
Signed-off-by: Maor <maor.friedman@nuvo-group.com>
/assign @maver1ck |
/ok-to-test |
destination: s3://bucket/cassandra | ||
|
||
# Copy n files in parallel | ||
# 0 for full parallelism | ||
parallel: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to maintain default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always feel that the values.yaml
file should provide an easy interface to change things when you need, instead of digging in the templates...
when increasing parallelism - it increases resource usage, so I think it is better left for the user to decide.
What do you think?
What this PR does / why we need it:
Change the image to the official image by our company
Allow control over level of parallelism in backup process